Feat: pool adapter #101
Open
Feat: pool adapter #101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abnegate
reviewed
May 20, 2025
| public function delegate(string $method, array $args): mixed | ||
| { | ||
| return $this->pool->use(function (Redis $redis) use ($method, $args) { | ||
| $adapter = new RedisAdapter($this->key, $this->limit, $this->seconds, $redis); |
Member
There was a problem hiding this comment.
Can we instantiate the adapter in the pool init function instead? This way, we instantiate a new adapter for every call
Contributor
Author
There was a problem hiding this comment.
I did not see a clear path to implement it that way in the init function creating a pool of timeLimit :(
There was a problem hiding this comment.
This is not gonna work. The adapters set the $count on the instance, if you create a new instance for every call, it's always gonna be 0.
We can't use the proxy approach here, you need to refactor the adapters to take a pool itself instead of wrapping them.
Co-authored-by: Jake Barnby <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.