fix: css_selector ignored in LXML scraping for raw:// URLs (#1484)#1833
Open
hafezparast wants to merge 1 commit intounclecode:developfrom
Open
fix: css_selector ignored in LXML scraping for raw:// URLs (#1484)#1833hafezparast wants to merge 1 commit intounclecode:developfrom
hafezparast wants to merge 1 commit intounclecode:developfrom
Conversation
…#1484) css_selector was skipped in _scrap() — only target_elements was applied. Now css_selector filters the DOM first, then target_elements narrows within that selection. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
css_selectordoesn't work Buttarget_elementsdoes! #1484css_selectorwas ignored in_scrap()— onlytarget_elementswas applied to the DOM. Nowcss_selectorfilters first, thentarget_elementsnarrows within that selection.Changes
crawl4ai/content_scraping_strategy.py: Addedcss_selectorfiltering beforetarget_elementsprocessing;target_elementsnow searches within the css_selector result instead of the full bodyTest plan
tests/test_issue_1484_css_selector.py(10 tests)Generated with Claude Code