Skip to content

Fix template sync after release#4887

Closed
zbeyens wants to merge 1 commit intomainfrom
templates/release-sync-failure
Closed

Fix template sync after release#4887
zbeyens wants to merge 1 commit intomainfrom
templates/release-sync-failure

Conversation

@zbeyens
Copy link
Copy Markdown
Member

@zbeyens zbeyens commented Mar 24, 2026

Template sync after release produced changes but did not pass automation.

  • pnpm templates:update --local: success
  • template CI: failure

@zbeyens zbeyens requested a review from a team March 24, 2026 10:11
@vercel
Copy link
Copy Markdown

vercel bot commented Mar 24, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
plate Ready Ready Preview, Comment Mar 24, 2026 10:15am

Request Review

@codesandbox
Copy link
Copy Markdown

codesandbox bot commented Mar 24, 2026

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Mar 24, 2026
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Mar 24, 2026

⚠️ No Changeset found

Latest commit: f3e25a7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dosubot dosubot bot added the build label Mar 24, 2026
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: f3e25a7045

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

"postcss": "^8.5.8",
"tailwindcss": "4.2.2",
"typescript": "5.9.3",
"typescript": "6.0.2",
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Keep TypeScript within parser's supported range

This commit pins typescript to 6.0.2, but the same template lockfile still resolves @typescript-eslint/parser@8.57.2 with a peer constraint of typescript >=4.8.4 <6.0.0 (templates/plate-template/bun.lock:383, and similarly in templates/plate-playground-template/bun.lock:675). That creates an unsupported eslint/type parser toolchain for generated apps, which can fail in environments that enforce peer deps and can produce unstable lint/type-aware behavior; either keep TypeScript on 5.x or upgrade the eslint parser stack to a version that explicitly supports TS 6 in both templates.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build size:S This PR changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant