Add turbo version of baroclinic instability #128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## ma/patch #128 +/- ##
============================================
- Coverage 97.30% 92.00% -5.31%
============================================
Files 30 31 +1
Lines 3903 4128 +225
============================================
Hits 3798 3798
- Misses 105 330 +225 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
MarcoArtiano
commented
Nov 26, 2025
| # For optimal results consider increasing the resolution to 16x16x8 trees per cube face, i.e., | ||
| # set `trees_per_cube_face = (16, 8)` below. | ||
| # | ||
| # This elixir takes about 8 hours, using 16 threads of an AMD Ryzen 7 7800X3D. |
Collaborator
Author
There was a problem hiding this comment.
Suggested change
| # This elixir takes about 8 hours, using 16 threads of an AMD Ryzen 7 7800X3D. | |
| # This elixir takes about 1 hours, using 16 threads of an AMD Ryzen 7 7800X3D. |
Member
There was a problem hiding this comment.
Are you still using the same hardware as described there?
ranocha
requested changes
Nov 26, 2025
Comment on lines
+16
to
+30
| @inline Trixi.combine_conservative_and_nonconservative_fluxes(::typeof(flux_kennedy_gruber_souza_etal_turbo), | ||
| equations::CompressibleEulerEnergyEquationsWithGravity3D) = Trixi.True() | ||
|
|
||
| @inline function flux_lmars_turbo(u_ll, u_rr, normal_direction, equations) | ||
| flux = FluxLMARS(340)(u_ll, u_rr, normal_direction, equations) | ||
| return flux, flux | ||
| end | ||
|
|
||
| @inline Trixi.combine_conservative_and_nonconservative_fluxes(::typeof(flux_lmars_turbo), equations::CompressibleEulerEnergyEquationsWithGravity3D) = Trixi.True() | ||
|
|
||
| @inline function boundary_condition_slip_wall(u_inner, | ||
| normal_direction::AbstractVector, | ||
| x, t, | ||
| surface_flux_function::typeof(flux_lmars_turbo), | ||
| equations::CompressibleEulerEnergyEquationsWithGravity3D) |
Member
There was a problem hiding this comment.
Can you please add a comment describing what you are doing here and why?
Comment on lines
+48
to
+50
| # Unperturbed balanced steady-state. | ||
| # Returns primitive variables with only the velocity in longitudinal direction (rho, u, p). | ||
| # The other velocity components are zero. |
Member
There was a problem hiding this comment.
I guess the remaining part is just copied from another elixir?
Comment on lines
+1
to
+3
| using Trixi: True, get_contravariant_vector, multiply_add_to_node_vars!, @threaded, | ||
| get_surface_node_vars, get_normal_direction, get_node_coords, @turbo, PtrArray, | ||
| StrideArray |
Member
There was a problem hiding this comment.
Suggested change
| using Trixi: True, get_contravariant_vector, multiply_add_to_node_vars!, @threaded, | |
| get_surface_node_vars, get_normal_direction, get_node_coords, @turbo, PtrArray, | |
| StrideArray | |
| using Trixi: True, get_contravariant_vector, multiply_add_to_node_vars!, @threaded, | |
| get_surface_node_vars, get_normal_direction, get_node_coords, @turbo, PtrArray, | |
| StrideArray, flux_kennedy_gruber |
ranocha
reviewed
Nov 26, 2025
| @test_allocations(TrixiAtmo.Trixi.rhs!, semi, sol, 100) | ||
| end | ||
|
|
||
| @trixi_testset "elixir_euler_energy_baroclinic_instability" begin |
Member
There was a problem hiding this comment.
Suggested change
| @trixi_testset "elixir_euler_energy_baroclinic_instability" begin | |
| @trixi_testset "elixir_euler_energy_baroclinic_instability with turbo flux" begin |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR the new performance specialization for the nonconservative fluxes is being used, along with the definition of a new turbo flux, based on the same principles.