fix: broken CSV cell by backslash escaped quoteChar #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So far CSVRecordReader detects '\' before quoteChar (usually ") and do unexpected string truncation. - [\"] -> keep parsing the rest This commit removes this weird behavior and no longer does this string truncation. - [\"] -> add \ and " then moves to next cell This commit also removes special '\' handling for '\\"'. This conditional branch is unnecessary because it does the same thing with 'else' branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far CSVRecordReader detects '' before quoteChar (usually ") and do
unexpected string truncation.
This commit removes this weird behavior and no longer does this string
truncation.
This commit also removes special '' handling for '"'. This
conditional branch is unnecessary because it does the same thing with
'else' branch.