Skip to content

Conversation

@chezou
Copy link
Member

@chezou chezou commented Nov 3, 2025

Also, dropping pyopenssl test in tox because it was resolved 6 years ago.

@chezou chezou requested review from Copilot and tung-vu-td November 3, 2025 20:39
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR modernizes the project's dependency management and testing infrastructure by migrating from pip/requirements.txt to uv, updating Python version support, and removing outdated PyOpenSSL workarounds. The changes consolidate dependency specifications into pyproject.toml, update CI workflows, and simplify the codebase.

Key changes:

  • Migrates from pip to uv for dependency management
  • Drops support for Python 3.5-3.9, adds support for Python 3.13-3.14
  • Removes PyOpenSSL-specific workarounds that are no longer needed
  • Consolidates dependencies into pyproject.toml optional-dependencies

Reviewed Changes

Copilot reviewed 11 out of 13 changed files in this pull request and generated no comments.

Show a summary per file
File Description
uv.lock New lockfile generated by uv containing all project dependencies
tox.ini Updated to use tox-uv, removed old Python versions, added typecheck environment
test-requirements.txt Removed (migrated to pyproject.toml)
requirements.txt Removed (migrated to pyproject.toml)
MANIFEST.in Removed (no longer needed with modern packaging)
pyproject.toml Added test optional-dependencies group and updated dev/docs groups
tdclient/api.py Removed PyOpenSSL workarounds for bytearray/array handling
tdclient/test/api_test.py Removed conditional assertions for PyOpenSSL behavior
tdclient/import_api.py Renamed parameters to avoid shadowing built-ins
tdclient/bulk_import_api.py Renamed parameters to avoid shadowing built-ins
README.rst Updated documentation to reflect uv usage
.python-version Updated to Python 3.10-3.14
.github/workflows/pythontest.yml Updated CI to use uv instead of pip

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

@tung-vu-td tung-vu-td left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chezou chezou merged commit b39c64e into master Nov 4, 2025
19 checks passed
@chezou chezou deleted the uv branch November 4, 2025 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants