✨ feat(discovery): add predicate parameter to get_interpreter#31
Merged
gaborbernat merged 1 commit intotox-dev:mainfrom Feb 26, 2026
Merged
✨ feat(discovery): add predicate parameter to get_interpreter#31gaborbernat merged 1 commit intotox-dev:mainfrom
predicate parameter to get_interpreter#31gaborbernat merged 1 commit intotox-dev:mainfrom
Conversation
Hatch monkeypatches `propose_interpreters` to filter out incompatible interpreters, which broke when virtualenv moved discovery to this package. Adding a `predicate` callback gives downstream tools a public API to filter interpreters without monkeypatching internals. Named `predicate` instead of `filter` to avoid shadowing the Python builtin (ruff A002). Closes tox-dev#30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hatch monkeypatches
propose_interpretersto filter out incompatible interpreters, which broke when virtualenv moved discovery into this package. There's currently no public API for downstream tools to reject interpreters that match a spec but fail some external constraint (e.g. platform compatibility). ✨ This adds apredicatecallback toget_interpreterso tools like Hatch can filter without monkeypatching internals.The
predicateis evaluated after an interpreter satisfies the spec, giving callers a clean hook to accept or reject candidates while the discovery loop continues searching on rejection. Namedpredicateinstead offilterto avoid shadowing the Python builtin (ruffA002rule). The parameter defaults toNone, so existing callers are unaffected.📝 Sphinx docstrings were added to all public API methods and properties across
ContentStore,PyInfoCache,DiskCache,PythonInfo,PythonSpec, andSimpleSpecifierSet.SimpleSpecifierSetis now also exported from the top-level package for downstream use.Closes #30