Make calculations more consistent#335
Merged
tolik518 merged 2 commits intotolik518:masterfrom Mar 7, 2026
Merged
Conversation
parse small "digits"s and "tower"s as integer calculate more exact termial of "digits" do not write 1 × in truncate do not return rough as true in truncate when only zeroes were cut only turn "approx" and "digits" into integers when below integer_contruction_limit
Owner
|
I can't pull the master-branch from my repo into your fork and I don't trust myself resolving the conflicts inside the calculation_results - could you please resolve the conflicts? @Aras14HD |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As asked here, made calculations more consistent when writing in different ways.
For that this parses small
10^and^(...)10expressions as integers.To not break previous calculations too much,
1 ×is left away intruncateand rough is not returned as true intruncatewhen only zeroes were cut .Additionally for correctness and performance,
ApproximateandApproximateDigitsare only turned into integers when below theinteger_construction_limitand calculates termial ofApproximateDigitslikeApproximate.