Conversation
|
You have run out of free Bugbot PR reviews for this billing cycle. This will reset on March 7. To receive reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial. |
✱ Stainless preview buildsThis PR will update the
|
blainekasten
left a comment
There was a problem hiding this comment.
Approving to unblock, but a few things to follow up on
| format: int64 | ||
| example: 1 | ||
| default: 1 | ||
| default: "1" |
There was a problem hiding this comment.
Why would the default be a string on an integer type?
| type: number | ||
| example: 1 | ||
| default: 1.0 | ||
| format: float |
There was a problem hiding this comment.
All of these format fields do nothing afaik
| - 789 | ||
| items: | ||
| type: integer | ||
| type: string |
| - TRAINING_OPERATION_ERROR_CODE_TIMEOUT | ||
| - TRAINING_OPERATION_ERROR_CODE_INTERNAL_ERROR | ||
| - TRAINING_OPERATION_ERROR_CODE_SESSION_NOT_ACTIVE | ||
| default: TRAINING_OPERATION_ERROR_CODE_UNSPECIFIED |
There was a problem hiding this comment.
A default doesn't really make sense here
| type: array | ||
| items: | ||
| type: object | ||
| $ref: '#/components/schemas/ProtobufAny' |
There was a problem hiding this comment.
We shouldn't be exposing any rpc concepts in the http api
No description provided.