Open
Conversation
Member
Author
|
This fixes #5195, although compilation of these intrinsics may still explode on arm due to llvm/llvm-project#140445 |
dgryski
requested changes
Feb 9, 2026
Member
dgryski
left a comment
dgryski
left a comment
There was a problem hiding this comment.
Some questions about names and tests.
Member
Author
|
Just realized I hadn't marked this as draft |
Member
Author
|
I managed to test this via a linkname, so I think this is okay now. |
eliasnaur
reviewed
Feb 10, 2026
dgryski
approved these changes
Feb 18, 2026
Member
dgryski
left a comment
dgryski
left a comment
There was a problem hiding this comment.
Some questions about the tests but otherwise LGTM.
The compiler may generate calls to fminimum/fmaximum on some platforms. Neither of the libm implementations we statically link against have these functions yet. Implement them ourselves.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The compiler may generate calls to fminimum/fmaximum on some platforms. Neither of the libm implementations we statically link against have these functions yet. Implement them ourselves.
I am not really sure how to test this properly because LLVM can (and usually will) rewrite any calls to these functions.