-
Notifications
You must be signed in to change notification settings - Fork 88
Add Nexus worker service for server-to-worker commands #708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rkannan82
wants to merge
4
commits into
kannan/add-worker-instance-key-to-wft-complete
Choose a base branch
from
kannan/activity-cancel
base: kannan/add-worker-instance-key-to-wft-complete
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+84
−0
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
cfff488
Add worker_control_task_queue to poll and respond protos
rkannan82 97d9221
Merge kannan/add-worker-instance-key-to-wft-complete into kannan/acti…
rkannan82 763e9f5
Address review: rename to ExecuteCommands, add response doc
rkannan82 63fca37
Address review: extract command types to worker/v1/message.proto
rkannan82 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
28 changes: 28 additions & 0 deletions
28
temporal/api/nexusservices/workerservice/v1/request_response.proto
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| syntax = "proto3"; | ||
|
|
||
| package temporal.api.nexusservices.workerservice.v1; | ||
|
|
||
| option go_package = "go.temporal.io/api/nexusservices/workerservice/v1;workerservice"; | ||
| option java_package = "io.temporal.api.nexusservices.workerservice.v1"; | ||
| option java_multiple_files = true; | ||
| option java_outer_classname = "RequestResponseProto"; | ||
| option ruby_package = "Temporalio::Api::Nexusservices::Workerservice::V1"; | ||
| option csharp_namespace = "Temporalio.Api.Nexusservices.Workerservice.V1"; | ||
|
|
||
| import "temporal/api/worker/v1/message.proto"; | ||
|
|
||
| // (-- | ||
| // Internal Nexus service for server-to-worker communication. | ||
| // See service.yaml for the service definition. | ||
| // --) | ||
|
|
||
| // Request payload for the "ExecuteCommands" Nexus operation. | ||
| message ExecuteCommandsRequest { | ||
| repeated temporal.api.worker.v1.WorkerCommand commands = 1; | ||
| } | ||
|
|
||
| // Response payload for the "ExecuteCommands" Nexus operation. | ||
| // The results list must be 1:1 with the commands list in the request (same size and order). | ||
| message ExecuteCommandsResponse { | ||
| repeated temporal.api.worker.v1.WorkerCommandResult results = 1; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| # yaml-language-server: $schema=https://raw.githubusercontent.com/nexus-rpc/nexus-rpc-gen/main/schemas/nexus-rpc-gen.json | ||
| # | ||
| # Nexus service definition for server-to-worker communication. | ||
| # See request_response.proto for message definitions. | ||
| # | ||
| # Task queue format: /temporal-sys/worker-commands/{namespace}/{worker_grouping_key} | ||
|
|
||
| nexusrpc: 1.0.0 | ||
|
|
||
| services: | ||
| temporal.api.nexusservices.workerservice.v1.WorkerService: | ||
| description: > | ||
| Internal Nexus service for server-to-worker communication. | ||
| Used by the Temporal server to send commands to workers. | ||
| operations: | ||
| ExecuteCommands: | ||
| description: Executes worker commands sent by the server. | ||
| input: | ||
| $goRef: "go.temporal.io/api/nexusservices/workerservice/v1.ExecuteCommandsRequest" | ||
| $javaRef: "io.temporal.api.nexusservices.workerservice.v1.ExecuteCommandsRequest" | ||
| $pythonRef: "temporalio.api.nexusservices.workerservice.v1.ExecuteCommandsRequest" | ||
| $typescriptRef: "@temporalio/api/nexusservices/workerservice/v1.ExecuteCommandsRequest" | ||
| $dotnetRef: "Temporalio.Api.Nexusservices.Workerservice.V1.ExecuteCommandsRequest" | ||
| $rubyRef: "Temporalio::Api::Nexusservices::Workerservice::V1::ExecuteCommandsRequest" | ||
| output: | ||
| $goRef: "go.temporal.io/api/nexusservices/workerservice/v1.ExecuteCommandsResponse" | ||
| $javaRef: "io.temporal.api.nexusservices.workerservice.v1.ExecuteCommandsResponse" | ||
| $pythonRef: "temporalio.api.nexusservices.workerservice.v1.ExecuteCommandsResponse" | ||
| $typescriptRef: "@temporalio/api/nexusservices/workerservice/v1.ExecuteCommandsResponse" | ||
| $dotnetRef: "Temporalio.Api.Nexusservices.Workerservice.V1.ExecuteCommandsResponse" | ||
| $rubyRef: "Temporalio::Api::Nexusservices::Workerservice::V1::ExecuteCommandsResponse" | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.