Conversation
| @@ -0,0 +1,33 @@ | |||
| import assert from 'assert'; | |||
Member
There was a problem hiding this comment.
Looks like you didn't git mv here before changing it, so git lost the history. Not a big deal, but also something that could be corrected.
Member
Author
There was a problem hiding this comment.
I don't think git actually works like that.
That is, I am pretty sure there is nothing special about git mv as opposed to just adding removing, renaming, and re-adding.
michaelficarra
approved these changes
Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Claude did this but I reviewed and it looks fine. Couple places that use
as unknown as whatevercasts that I'd do// @ts-expect-errorbut nothing wrong with being more verbose. Commits can be reviewed individually. Fixes #667.Also removes Mocha because node's built-in runner is fine, and bumps minimum node version to 24 because I don't want to bother having to compile the test files. This makes it a breaking change. We should probably start publishing as ESM while we're at it, just to simplify the build process, but that can be a followup.