Add create_if_missing option to add-lines configurator
#1075
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
changed the title
create_if_missing option to add-lines configurator
OskarStark
force-pushed
the
OskarStark/add-lines-create-if-missing
branch
from
aea243b to
2eec7f6
Compare
This option allows specifying YAML content that should be created
when the target is not found in the file. The content is appended
to the file followed by the regular content.
Example usage:
{
"add-lines": [{
"file": "config/packages/ai.yaml",
"position": "after_target",
"target": " store:",
"create_if_missing": "ai:\n store:",
"content": " azuresearch:\n ..."
}]
}
OskarStark
force-pushed
the
OskarStark/add-lines-create-if-missing
branch
from
2eec7f6 to
3a928f6
Compare
Member
|
We can maybe close this PR? |
Member
|
My proposal in symfony/recipes#1503 (comment) would make this PR unnecessary (adding one more advantage to the list) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
In
symfony/aiwe basically have an "empty"ai.yamlfile, as no stores are configured as default. When adding your first store you are not able to leverage the recipe otherwise.cc @chr-hertel
Summary
This PR adds a
create_if_missingoption to theadd-linesconfigurator. When usingposition: after_target, if the target is not found in the file, the content specified increate_if_missingwill be appended to the file, followed by the regularcontent.Example usage:
{ "add-lines": [{ "file": "config/packages/ai.yaml", "position": "after_target", "target": " store:", "create_if_missing": "ai:\n store:", "content": " azuresearch:\n default:\n endpoint: '%env(AZURE_SEARCH_ENDPOINT)%'" }] }Behavior:
store:exists → Content is added after it (existing behavior)store:doesn't exist butcreate_if_missingis set → Thecreate_if_missingcontent is appended to the file, followed by thecontentstore:doesn't exist andcreate_if_missingis not set → Warning is logged (existing behavior)