[Platform] Add FailoverPlatform
#1126
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Guikingone
changed the title
Failover platformFailoverPlatform
Guikingone
force-pushed
the
platform/fallback
branch
5 times, most recently
from
03b2077 to
2216da4
Compare
carsonbot
added
Feature
Guikingone
force-pushed
the
platform/fallback
branch
from
2216da4 to
2d71028
Compare
OskarStark
reviewed
Dec 16, 2025
Guikingone
force-pushed
the
platform/fallback
branch
from
d3d5e17 to
9408d98
Compare
Contributor
Author
|
Well, that's a weird one, no changes on my side and the class is not found by the bundle, what the funk is this behavior? 🤔 |
Contributor
|
Please rebase |
OskarStark
reviewed
Dec 17, 2025
OskarStark
reviewed
Dec 17, 2025
| */ | ||
| public function __construct( | ||
| private readonly iterable $platforms, | ||
| private readonly ClockInterface $clock = new MonotonicClock(), |
Contributor
There was a problem hiding this comment.
why not using the rate limiter component here?
Contributor
Author
There was a problem hiding this comment.
Because I thought Clock would be easier but it's quite the opposite 😅
I'll take a look at using the rate limiter 👍🏻
OskarStark
reviewed
Dec 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This platform was a POC that I launched a few weeks ago locally (mostly for
OllamaandOpenAIas a backup in a context of another POC -more on the other one if I find time to finish the tests-), not totally convinced by the current implementation but debates can lead to improvements so here it is 😅PS: No configuration for now as the
options.phpmust be improved on my side to handle the platforms.