Enable libcurl websocket support for Android SDK #522
+1
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported at skiptools/skip#559 and https://github.com/orgs/skiptools/discussions/568, the Swift SDK for Android's libcurl used by FoundationNetworking is not being built with websockets support, resulting in a fatalError when trying to use
URLSession.websocketTask()orURLSessionWebSocketTask:All we need to do is turn it on with
ENABLE_WEBSOCKETS=ON. When building this PR separately (see artifacts at https://github.com/swift-android-sdk/swift-docker/actions/runs/20467831234) and copying over the newlibFoundationNetworking.so, the test passes:CC @swiftlang/android-workgroup
@al45tair: you may want to do the same for the Static SDK, since I expect you would also see similar websocket failures.
Here's the full test program for reference: