Skip to content

Conversation

@singh-inder
Copy link
Contributor

@singh-inder singh-inder commented Feb 11, 2026

What kind of change does this PR introduce?

Bug fix

What is the current behavior?

  1. If a function dir with index.ts is present on disk but not defined in config.toml, it is still deployed. I assume this isn't expected behavior.
    To Reproduce:

    • run: supabase functions new should-not-upload
    • comment out/remove this function's config from config.toml
    • run: supabase functions deploy --use-api
    • function is still deployed.
    image Screenshot from 2026-02-12 03-07-38-final
  2. deploy success msg is shown for all function slugs, even the ones which aren't deployed. Also the slugs slice contains duplicates, so does the msg derived from slugs slice

    should-not-upload is disabled functions.should-not-upload.enabled=false but the deploy success msg still prints this slug and msg contains duplicates.
    Screenshot from 2026-02-12 01-07-17-final

What is the new behavior?

  • dont upload functions if not defined in config.toml. <function>.enabled behavior remains same.
  • dedup slugs returned from GetFunctionSlugs and only print deploy success msg for functions actually deployed.

@singh-inder singh-inder requested a review from a team as a code owner February 11, 2026 21:50
@coveralls
Copy link

coveralls commented Feb 11, 2026

Pull Request Test Coverage Report for Build 21938689309

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 9 of 9 (100.0%) changed or added relevant lines in 1 file are covered.
  • 5 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.005%) to 61.792%

Files with Coverage Reduction New Missed Lines %
internal/utils/git.go 5 57.14%
Totals Coverage Status
Change from base Build 21910846003: -0.005%
Covered Lines: 7711
Relevant Lines: 12479

💛 - Coveralls

@singh-inder
Copy link
Contributor Author

singh-inder commented Feb 11, 2026

I think loop iteration can be skipped here.

if !ok {
			function.Enabled = false
			function.VerifyJWT = true
     		functionConfig[name] = function
     		continue
		}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants