Garmin: Standardise the Firmware Version Reporting.#102
Merged
mikeller merged 2 commits intosubsurface:Subsurface-DS9from Feb 14, 2026
Merged
Conversation
7 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
This PR standardizes the “extra info” string key used to report device firmware versions across multiple parsers, aligning with Subsurface’s expectation of the key name.
Changes:
- Introduces a shared firmware-version key macro (
STRING_KEY_FW_VERSION) in the public parser header. - Updates several device parsers (Garmin, Suunto Eon Steel, Shearwater Predator, HW OSTC) to use the standardized key instead of ad-hoc strings.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
src/suunto_eonsteel_parser.c |
Uses the shared firmware-version string key for Suunto device info. |
src/shearwater_predator_parser.c |
Uses the shared firmware-version string key when caching device firmware. |
src/hw_ostc_parser.c |
Uses the shared firmware-version string key when returning firmware as a string field. |
src/garmin_parser.c |
Renames Garmin’s firmware extra-info key from "Firmware" to the standardized firmware key. |
include/libdivecomputer/parser.h |
Adds STRING_KEY_FW_VERSION macro for consistent firmware key usage. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Standardise on 'FW Version' as the Extra Info key to report the firmware under, because Subsurface is using this key to look up the firmware version. Signed-off-by: Michael Keller <github@ike.ch>
mikeller
force-pushed
the
standardise_firmware_version_reporting
branch
from
3a9b9b1 to
ebb36b1
Compare
Signed-off-by: Michael Keller <github@ike.ch>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Standardise on 'FW Version' as the Extra Info key to report the firmware
under, because Subsurface is using this key to look up the firmware
version.
Signed-off-by: Michael Keller github@ike.ch