Fix encoder vs output shutdown crash#1635
Open
aleksandr-voitenko wants to merge 2 commits intostagingfrom
Open
Fix encoder vs output shutdown crash#1635aleksandr-voitenko wants to merge 2 commits intostagingfrom
aleksandr-voitenko wants to merge 2 commits intostagingfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR reduces shutdown-time crashes in
obs-studio-nodeby making shutdown wait for all active outputs to fully stop before cleanup continues. The change is made innodeobs_service.cppand is intended to avoid races where streaming/recording resources are destroyed while OBS output threads are still active.The stack trace from Sentry. See, for example an issue with ID
2a0f8364The stack trace is not really meaningful, but logs associated with the issue are the real source of insight.
What changed
How Has This Been Tested?
Manually, Windows only.
Types of changes