Lookup blockdev D-Bus properties without raising not found exception #1250
Draft
mulkieran wants to merge 6 commits intostratis-storage:masterfrom
Draft
Lookup blockdev D-Bus properties without raising not found exception #1250mulkieran wants to merge 6 commits intostratis-storage:masterfrom
mulkieran wants to merge 6 commits intostratis-storage:masterfrom
Conversation
mulkieran
force-pushed
the
do-not-terminate-on-missing-pool
branch
2 times, most recently
from
444eeb3 to
4320d2b
Compare
mulkieran
changed the title
mulkieran
force-pushed
the
do-not-terminate-on-missing-pool
branch
2 times, most recently
from
f9da5c0 to
7eb1526
Compare
Member
Author
|
We should do this for filesystem also, most likely. |
Member
Author
|
We will have to have a plan to patch lookup methods like devs or pools or filesystems or fall back on just treating the GetManagedObjects result like a dict. |
mulkieran
force-pushed
the
do-not-terminate-on-missing-pool
branch
from
7eb1526 to
43dd2f9
Compare
mulkieran
force-pushed
the
do-not-terminate-on-missing-pool
branch
7 times, most recently
from
58d628e to
c1874e3
Compare
The alerts regarding device size changes require searching the GetManagedObjects result, the other alerts only require looking at the properties of one pool. Calculating them together is awkward. Signed-off-by: mulhern <amulhern@redhat.com>
The are already sorted in table view, so might as well be consistent. Signed-off-by: mulhern <amulhern@redhat.com>
To better localize D-Bus property using methods. Signed-off-by: mulhern <amulhern@redhat.com>
mulkieran
force-pushed
the
do-not-terminate-on-missing-pool
branch
from
c1874e3 to
565cc08
Compare
mulkieran
force-pushed
the
do-not-terminate-on-missing-pool
branch
from
565cc08 to
3350c4a
Compare
Signed-off-by: mulhern <amulhern@redhat.com>
Signed-off-by: mulhern <amulhern@redhat.com>
zbus crate omits property values from the GetManagedObjects result if it can not get them. Instead of a stack trace, return a TABLE_UNKNOWN_STRING for printing. Signed-off-by: mulhern <amulhern@redhat.com>
mulkieran
force-pushed
the
do-not-terminate-on-missing-pool
branch
from
3350c4a to
b3c9539
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related stratis-storage/stratisd#3947