[CAP-77] Exclude issuer trustlines from the frozen keys.#1891
Merged
dmkozh merged 2 commits intostellar:masterfrom Mar 6, 2026
Merged
[CAP-77] Exclude issuer trustlines from the frozen keys.#1891dmkozh merged 2 commits intostellar:masterfrom
dmkozh merged 2 commits intostellar:masterfrom
Conversation
Also add rationale on the supported key types.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates CAP-0077 to explicitly disallow freezing “issuer trustlines” and adds design rationale explaining which ledger key types are intentionally supported/unsupported.
Changes:
- Extend
frozenLedgerKeysDeltavalidation rules to reject issuer trustline keys (in addition to pool share trustlines). - Add a “Unsupported key types” rationale section describing why certain ledger entry types are excluded.
- Minor wording adjustment in the DEX-handling rationale.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
sisuresh
reviewed
Mar 6, 2026
sisuresh
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also add rationale on the supported key types.