13.0

.github/workflows/documentation.yml

@@ -10,7 +10,7 @@ on:
 
 jobs:
   documentation:
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-22.04
     env:
       DB: "openupgrade"
       DB_USERNAME: "odoo"
@@ -23,14 +23,16 @@ jobs:
       PGUSER: "odoo"
     steps:
       - name: Set up Python
-        uses: actions/setup-python@v2
+        uses: actions/setup-python@v5
         with:
           python-version: 3.7
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v4
       - name: Configuration
         run: |
           sudo apt update
           sudo apt install libldap2-dev nodejs libxml2-dev libxslt1-dev libevent-dev libsasl2-dev expect unixodbc-dev expect-dev python3-lxml python3-simplejson python3-serial python3-yaml python3-passlib python3-psycopg2 python3-werkzeug
+          pip install wheel
+          pip install --no-build-isolation vatnumber==1.2
           pip install -r requirements.txt
           pip install sphinx
       - name: OpenUpgrade Docs

.github/workflows/flake.yml

@@ -13,12 +13,12 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Set up Python
-        uses: actions/setup-python@v2
+        uses: actions/setup-python@v5
         with:
-          python-version: 3.7
-      - uses: actions/checkout@v2
+          python-version: 3.8
+      - uses: actions/checkout@v4
       - name: Configuration
-        run: pip install flake8==3.4.1
+        run: pip install flake8==4.0.1
       - name: Flake8 Script
         run: |
           flake8 odoo/openupgrade --max-line-length=120
@@ -27,4 +27,7 @@ jobs:
           # only flake8 migration scripts from the openupgrade project, presumably
           # identifiable by using the openupgrade helpers
           flake8 --max-line-length=120 scripts $(find . \( -name 'pre-*.py' -or -name 'post-*.py' -or -name 'end-*.py' \) -exec grep -q openupgrade {} \; -print)
-          flake8 addons/*/migrations/*/tests/ --max-line-length=120
+          if ls addons/*/migrations/*/tests/ > /dev/null 2>&1; then
+            flake8 addons/*/migrations/*/tests/ --max-line-length=120 --filename=__init__.py --ignore=F401
+            flake8 addons/*/migrations/*/tests/ --max-line-length=120 --exclude=__init__.py
+          fi

.github/workflows/test.yml

@@ -10,7 +10,7 @@ on:
 
 jobs:
   test:
-    runs-on: ubuntu-latest
+    runs-on: ubuntu-22.04
     env:
       DB: "openupgrade"
       DB_USERNAME: "odoo"
@@ -23,7 +23,7 @@ jobs:
       PGUSER: "odoo"
     steps:
       - name: Set up Python
-        uses: actions/setup-python@v2
+        uses: actions/setup-python@v5
         with:
           python-version: 3.7
       - name: Configure Postgres
@@ -50,14 +50,16 @@ jobs:
           # Line below may fail quite often due to Travis bug:
           # - git reset -q --hard $TRAVIS_COMMIT
           # Install Python requirements of target release
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v4
       - name: Configuration
         run: |
           sudo apt update
           sudo apt install libldap2-dev nodejs libxml2-dev libxslt1-dev libevent-dev libsasl2-dev expect unixodbc-dev expect-dev python3-lxml python3-simplejson python3-serial python3-yaml python3-passlib python3-psycopg2 python3-werkzeug
       - name: Requirements Installation
         run: |
           sudo npm install -g less less-plugin-clean-css
+          pip install wheel
+          pip install --no-build-isolation vatnumber==1.2
           pip install -q -r requirements.txt
           # don't use pypi's openupgradelib, but the one from source to avoid choking
           # on unreleased features in openupgradelib

addons/account/migrations/13.0.1.1/openupgrade_analysis_work.txt

@@ -331,8 +331,9 @@ account      / account.move             / matched_percentage (float)    : DEL
 account      / account.move             / reverse_entry_id (many2one)   : DEL relation: account.move
 account      / account.move             / reversed_entry_id (many2one)  : NEW relation: account.move
 account      / account.invoice          / refund_invoice_id (many2one)  : DEL relation: account.invoice
-# DONE: pre-migration: renamed fields
-# DONE: post-migration: used refund_invoice_id to fill reversed_entry_id in case is empty
+# DONE: pre-migration: lift FK constraint in reverse_entry_id
+# DONE: post-migration: used refund_invoice_id to fill reverse_entry_id in case is empty (for invoices transformed to moves)
+# DONE: post-migration: used reverse_entry_id to fill reversed_entry_id in case is empty
 
 account      / account.move             / tax_type_domain (char)        : DEL
 # NOTHING TO DO: renamed to invoice_filter_type_domain, but still is non stored

addons/account/migrations/13.0.1.1/post-migration.py

@@ -296,7 +296,11 @@ def migration_invoice_moves(env):
         env.cr, """
         UPDATE account_move_line
         SET exclude_from_invoice_tab = TRUE
-        WHERE old_invoice_line_id IS NULL""",
+        FROM account_move
+        WHERE old_invoice_line_id IS NULL
+        AND account_move_line.move_id=account_move.id
+        AND account_move.type <> 'entry'
+        """,
     )
     # 4th. Adding all the missing lines
     openupgrade.logged_query(
@@ -577,14 +581,24 @@ def migration_voucher_moves(env):
 
 
 def fill_account_move_reversed_entry_id(env):
+    # copy refund_invoice_id to reverse_entry_id
     openupgrade.logged_query(
         env.cr, """
         UPDATE account_move am
-        SET reversed_entry_id = am2.id
+        SET reverse_entry_id = am2.id
         FROM account_invoice ai
         JOIN account_invoice ai2 ON ai.refund_invoice_id = ai2.id
         JOIN account_move am2 ON am2.old_invoice_id = ai2.id
-        WHERE am.reversed_entry_id IS NULL AND am.old_invoice_id = ai.id"""
+        WHERE am.reverse_entry_id IS NULL AND am.old_invoice_id = ai.id"""
+    )
+    # copy reverse_entry_id to reversed_entry_id (the relation is reversed in 13.0)
+    openupgrade.logged_query(
+        env.cr, """
+        UPDATE account_move am
+        SET reversed_entry_id = am2.id
+        FROM account_move am2
+        WHERE am.reversed_entry_id IS NULL AND am2.reverse_entry_id = am.id
+        """
     )
 
 
@@ -847,13 +861,21 @@ def create_account_tax_repartition_lines(env):
 def move_tags_from_taxes_to_repartition_lines(env):
     openupgrade.logged_query(
         env.cr, """
+        WITH RECURSIVE tax2parent(tax_id, parent_id) AS (
+            SELECT id, id FROM account_tax
+            UNION ALL
+            SELECT rel.child_tax, rel.parent_tax
+            FROM account_tax_filiation_rel rel
+            JOIN tax2parent ON tax2parent.parent_id=rel.child_tax
+        )
         INSERT INTO account_account_tag_account_tax_repartition_line_rel (
             account_tax_repartition_line_id, account_account_tag_id)
         SELECT atrl.id, atat.account_account_tag_id
         FROM account_tax_account_tag atat
+        JOIN tax2parent ON atat.account_tax_id=tax2parent.parent_id
         JOIN account_tax_repartition_line atrl ON
-            (atat.account_tax_id = atrl.invoice_tax_id OR
-             atat.account_tax_id = atrl.refund_tax_id)
+            (tax2parent.tax_id = atrl.invoice_tax_id OR
+             tax2parent.tax_id = atrl.refund_tax_id)
         ON CONFLICT DO NOTHING"""
     )
     openupgrade.logged_query(
@@ -940,14 +962,22 @@ def assign_account_tags_to_move_lines(env):
     # move lines with taxes
     openupgrade.logged_query(
         env.cr, """
+        WITH RECURSIVE tax2child(tax_id, child_id) AS (
+            SELECT id, id FROM account_tax
+            UNION ALL
+            SELECT rel.parent_tax, rel.child_tax
+            FROM account_tax_filiation_rel rel
+            JOIN tax2child ON tax2child.child_id=rel.parent_tax
+        )
         INSERT INTO account_account_tag_account_move_line_rel (
             account_move_line_id, account_account_tag_id)
         SELECT aml.id, aat_atr_rel.account_account_tag_id
         FROM account_move_line aml
         JOIN account_move am ON aml.move_id = am.id
         JOIN account_move_line_account_tax_rel amlatr ON amlatr.account_move_line_id = aml.id
+        JOIN tax2child ON amlatr.account_tax_id=tax2child.child_id
         JOIN account_tax_repartition_line atrl ON (
-            atrl.invoice_tax_id = amlatr.account_tax_id AND atrl.repartition_type = 'base')
+            atrl.invoice_tax_id = tax2child.tax_id AND atrl.repartition_type = 'base')
         JOIN account_account_tag_account_tax_repartition_line_rel aat_atr_rel ON
             aat_atr_rel.account_tax_repartition_line_id = atrl.id
         WHERE aml.old_invoice_line_id IS NOT NULL AND am.type in ('out_invoice', 'in_invoice')

addons/account/migrations/13.0.1.1/pre-migration.py

@@ -34,7 +34,6 @@
 
 _field_renames = [
     ('account.move', 'account_move', 'amount', 'amount_total'),
-    ('account.move', 'account_move', 'reverse_entry_id', 'reversed_entry_id'),
 ]
 
 _field_sale_renames = [
@@ -340,6 +339,7 @@ def migrate(env, version):
     fill_account_move_line(env)
     create_res_partner_ranks(env)
     delete_fk_constraints(env)
+    openupgrade.lift_constraints(env.cr, "account_move", "reverse_entry_id")
     fill_account_move_commercial_partner_id(env)
     set_account_move_currency_id_required(env)
     add_helper_invoice_move_rel(env)

addons/account_check_printing/migrations/13.0.1.0/post-migration.py

@@ -8,10 +8,12 @@ def map_account_payment_check_number(env):
     openupgrade.logged_query(
         env.cr, """
         UPDATE account_payment
-        SET check_number = '' || %s
+        SET check_number = %s::VARCHAR
         WHERE %s IS NOT NULL
-        """, (openupgrade.get_legacy_name('check_number'),
-              openupgrade.get_legacy_name('check_number'))
+        """ % (
+            openupgrade.get_legacy_name('check_number'),
+            openupgrade.get_legacy_name('check_number')
+        )
     )
 
 

addons/l10n_ch/migrations/13.0.11.0/noupdate_changes.xml

@@ -5,6 +5,6 @@
   </record>
   <record id="fiscal_position_template_import" model="account.fiscal.position.template">
     <field name="auto_apply" eval="True"/>
-    <field name="sequence">1</field>
+<!--    <field name="sequence">1</field>-->
   </record>
 </odoo>

addons/l10n_ch/migrations/13.0.10.0/openupgrade_analysis.txt → addons/l10n_ch/migrations/13.0.11.0/openupgrade_analysis_work.txt

@@ -1,14 +1,20 @@
 ---Models in module 'l10n_ch'---
 ---Fields in module 'l10n_ch'---
 l10n_ch      / account.invoice          / l10n_ch_isr_number (char)     : DEL
-l10n_ch      / account.invoice          / l10n_ch_isr_sent (boolean)    : DEL
-l10n_ch      / account.journal          / invoice_reference_model (False): NEW selection_keys: ['ch', 'euro', 'odoo'], mode: modify
 l10n_ch      / account.move             / l10n_ch_isr_number (char)     : NEW isfunction: function, stored
+l10n_ch      / account.invoice          / l10n_ch_isr_sent (boolean)    : DEL
 l10n_ch      / account.move             / l10n_ch_isr_sent (boolean)    : NEW hasdefault
+# DONE: post-migration: moved fields from invoice to move
+
+l10n_ch      / account.journal          / invoice_reference_model (False): NEW selection_keys: ['ch', 'euro', 'odoo'], mode: modify
+# NOTHING TO DO: new feature
+
 l10n_ch      / res.bank                 / l10n_ch_postal_chf (char)     : DEL
 l10n_ch      / res.bank                 / l10n_ch_postal_eur (char)     : DEL
 l10n_ch      / res.partner.bank         / l10n_ch_isr_subscription_chf (char): NEW
 l10n_ch      / res.partner.bank         / l10n_ch_isr_subscription_eur (char): NEW
+# DONE: post-migration: moved fields from bank to partner bank
+
 ---XML records in module 'l10n_ch'---
 DEL account.account.tag: l10n_ch.vat_tag_200
 DEL account.account.tag: l10n_ch.vat_tag_220
@@ -34,6 +40,13 @@ DEL account.account.tag: l10n_ch.vat_tag_415
 DEL account.account.tag: l10n_ch.vat_tag_420
 DEL account.account.tag: l10n_ch.vat_tag_dedouanement
 NEW account.account.template: l10n_ch.ch_coa_1101
+# NOTHING TO DO
+
+account.chart.template: l10n_ch.l10nch_chart_template (noupdate switched)
+# DONE: pre-migration: switched noupdate
+
+NEW account.fiscal.position.template: l10n_ch.fiscal_position_template_1 (noupdate)
+NEW account.tax.group: l10n_ch.tax_group_tva_100
 NEW account.tax.report.line: l10n_ch.account_tax_report_line_calc_impot
 NEW account.tax.report.line: l10n_ch.account_tax_report_line_calc_impot_base
 NEW account.tax.report.line: l10n_ch.account_tax_report_line_calc_impot_chiffre
@@ -70,11 +83,11 @@ NEW account.tax.report.line: l10n_ch.account_tax_report_line_chtax_900
 NEW account.tax.report.line: l10n_ch.account_tax_report_line_chtax_910
 NEW account.tax.report.line: l10n_ch.account_tax_report_line_chtax_autres_mouv
 NEW account.tax.report.line: l10n_ch.account_tax_report_line_chtax_solde
+NEW account.tax.template: l10n_ch.vat_100_import_invest
 NEW account.tax.template: l10n_ch.vat_other_movements_900
 NEW account.tax.template: l10n_ch.vat_other_movements_910
-NEW ir.actions.act_window: account.action_move_out_invoice_type
-DEL ir.actions.act_window: account.action_invoice_tree1
 NEW ir.ui.view: l10n_ch.isr_partner_bank_tree
 NEW ir.ui.view: l10n_ch.isr_partner_property_bank_tree
 NEW ir.ui.view: l10n_ch.setup_bank_account_wizard_inherit
 DEL ir.ui.view: l10n_ch.isr_res_bank_form
+# NOTHING TO DO

addons/l10n_ch/migrations/13.0.11.0/post-migration.py

@@ -0,0 +1,33 @@
+# Copyright 2021 ForgeFlow <http://www.forgeflow.com>
+# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).
+from openupgradelib import openupgrade
+
+
+def move_from_invoices_to_moves(env):
+    openupgrade.logged_query(
+        env.cr, """
+        UPDATE account_move am
+        SET l10n_ch_isr_number = ai.l10n_ch_isr_number,
+            l10n_ch_isr_sent = ai.l10n_ch_isr_sent
+        FROM account_invoice ai
+        WHERE am.old_invoice_id = ai.id""",
+    )
+
+
+def move_from_bank_to_partner_bank(env):
+    openupgrade.logged_query(
+        env.cr, """
+        UPDATE res_partner_bank rpb
+        SET l10n_ch_isr_subscription_chf = rb.l10n_ch_postal_chf,
+            l10n_ch_isr_subscription_eur = rb.l10n_ch_postal_eur
+        FROM res_bank rb
+        WHERE rpb.bank_id = rb.id""",
+    )
+
+
+@openupgrade.migrate()
+def migrate(env, version):
+    move_from_invoices_to_moves(env)
+    move_from_bank_to_partner_bank(env)
+    openupgrade.load_data(
+        env.cr, "l10n_ch", "migrations/13.0.11.0/noupdate_changes.xml")

addons/l10n_ch/migrations/13.0.11.0/pre-migration.py

@@ -0,0 +1,10 @@
+# Copyright 2021 ForgeFlow <http://www.forgeflow.com>
+# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).
+from openupgradelib import openupgrade
+
+
+@openupgrade.migrate()
+def migrate(env, version):
+    openupgrade.set_xml_ids_noupdate_value(
+        env, "l10n_ch", ["l10nch_chart_template"], False,
+    )

addons/l10n_es/migrations/13.0.4.0/pre-migration.py

@@ -47,7 +47,7 @@ def set_account_move_number_to_invoice_number(env):
     )
 
 
-def rename_food_taxes_xmlids(env):
+def rename_food_taxes_and_fiscal_positions_xmlids(env):
     renames = [
         ("account_tax_template_p_iva0_a", "account_tax_template_p_iva0_s_bc"),
         ("account_tax_template_p_iva5_a", "account_tax_template_p_iva5_bc"),
@@ -59,6 +59,19 @@ def rename_food_taxes_xmlids(env):
         ("account_tax_template_s_iva0_a", "account_tax_template_s_iva0b"),
         ("account_tax_template_s_iva5_a", "account_tax_template_s_iva5b"),
         ("account_tax_template_s_req0625", "account_tax_template_s_req062"),
+        ("fptt_extra_0a", "fptt_extra_0b"),
+        ("fptt_extra_5a", "fptt_extra_5b"),
+        ("fptt_intra_0a", "fptt_intra_0b"),
+        ("fptt_intra_5a", "fptt_intra_5b"),
+        ("fptt_reagyp_a_0a_2", "fptt_reagyp_a_4b_4"),
+        ("fptt_recargo_0a", "fptt_recargo_0b"),
+        ("fptt_recargo_0a_2", "fptt_recargo_0b_2"),
+        ("fptt_recargo_5a", "fptt_recargo_5b"),
+        ("fptt_recargo_5a_2", "fptt_recargo_5b_2"),
+        ("fptt_recargo_buy_0a", "fptt_recargo_buy_0b"),
+        ("fptt_recargo_buy_0a_2", "fptt_recargo_buy_0b_2"),
+        ("fptt_recargo_buy_5a", "fptt_recargo_buy_5b"),
+        ("fptt_recargo_buy_5a_2", "fptt_recargo_buy_5b_2"),
     ]
     companies = env["res.company"].with_context(active_test=False).search([])
     for old, new in renames:
@@ -80,4 +93,4 @@ def migrate(env, version):
     if openupgrade.column_exists(
             env.cr, "account_invoice", "invoice_number"):
         set_account_move_number_to_invoice_number(env)
-    rename_food_taxes_xmlids(env)
+    rename_food_taxes_and_fiscal_positions_xmlids(env)

addons/mrp/migrations/13.0.2.0/pre-migration.py

@@ -88,7 +88,7 @@ def mapped_reservation_state(env):
 
 @openupgrade.migrate()
 def migrate(env, version):
-    openupgrade.remove_tables_fks(env.cr, 'mrp_bom_line_product_attribute_value_rel')
+    openupgrade.remove_tables_fks(env.cr, ['mrp_bom_line_product_attribute_value_rel'])
     openupgrade.rename_models(env.cr, _model_renames)
     if openupgrade.table_exists(env.cr, 'mrp_subproduct'):
         openupgrade.rename_tables(env.cr, _mrp_subproduct_table_renames)

addons/pos_sale/migrations/13.0.1.0/openupgrade_analysis_work.txt

@@ -21,4 +21,8 @@ DEL crm.team: pos_sale.pos_sales_team [renamed to sales_team module] (noupdate)
 # NOTHING TO DO: renamed xmlids in sales_team
 
 DEL pos.config: point_of_sale.pos_config_main (noupdate)
-# DONE: post-migration: Try to delete record
+# NOTHING TO DO: point_of_sale.pos_config_main still exists in module
+    point_of_sale. Now the module pos_sale does not add a value for
+    crm_team_id in the xml file, it only rely on the default value
+    defined with a function in the model pos.config. The value set in
+    previous version should no be modified.