-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
feat: add blas/base/drotmg
#9724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
- task: lint_filenames
status: passed
- task: lint_editorconfig
status: passed
- task: lint_markdown
status: passed
- task: lint_package_json
status: passed
- task: lint_repl_help
status: passed
- task: lint_javascript_src
status: passed
- task: lint_javascript_cli
status: na
- task: lint_javascript_examples
status: passed
- task: lint_javascript_tests
status: passed
- task: lint_javascript_benchmarks
status: passed
- task: lint_python
status: na
- task: lint_r
status: na
- task: lint_c_src
status: missing_dependencies
- task: lint_c_examples
status: missing_dependencies
- task: lint_c_benchmarks
status: missing_dependencies
- task: lint_c_tests_fixtures
status: na
- task: lint_shell
status: na
- task: lint_typescript_declarations
status: passed
- task: lint_typescript_tests
status: passed
- task: lint_license_headers
status: passed
---
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
- task: lint_filenames
status: passed
- task: lint_editorconfig
status: passed
- task: lint_markdown
status: na
- task: lint_package_json
status: na
- task: lint_repl_help
status: na
- task: lint_javascript_src
status: na
- task: lint_javascript_cli
status: na
- task: lint_javascript_examples
status: na
- task: lint_javascript_tests
status: passed
- task: lint_javascript_benchmarks
status: passed
- task: lint_python
status: na
- task: lint_r
status: na
- task: lint_c_src
status: na
- task: lint_c_examples
status: na
- task: lint_c_benchmarks
status: na
- task: lint_c_tests_fixtures
status: na
- task: lint_shell
status: na
- task: lint_typescript_declarations
status: passed
- task: lint_typescript_tests
status: na
- task: lint_license_headers
status: passed
---
Coverage Report
The above coverage report was generated for the changes in this PR. |
Planeshifter
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some initial comments.
lib/node_modules/@stdlib/blas/base/drotmg/include/stdlib/blas/base/drotmg.h
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/blas/base/drotmg/include/stdlib/blas/base/drotmg_cblas.h
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/blas/base/drotmg/include/stdlib/blas/base/drotmg_fortran.h
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/blas/base/drotmg/docs/types/index.d.ts
Outdated
Show resolved
Hide resolved
| /** | ||
| * Constructs the parameters for a modified Givens plane rotation. | ||
| * | ||
| * @param d1 - scaling factor for the first vector component | ||
| * @param d2 - scaling factor for the second vector component | ||
| * @param x1 - first component of the first vector | ||
| * @param y1 - first component of the second vector | ||
| * @param out - output array | ||
| * @param stride - index increment | ||
| * @param offset - starting index | ||
| * @returns - output array containing the rotation parameters |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The JSDoc for this declaration includes parameters (out, stride, offset) that don't apply to the main function signature - those only apply to the assign method. The main signature is just ( d1, d2, x1, y1 ).
Should be:
/**
* Constructs the parameters for a modified Givens plane rotation.
*
* @param d1 - scaling factor for the first vector component
* @param d2 - scaling factor for the second vector component
* @param x1 - first component of the first vector
* @param y1 - first component of the second vector
* @returns - output array containing the rotation parameters
*
* @exampleSigned-off-by: Dhruv/ <154677013+DhruvArvindSingh@users.noreply.github.com>
|
Hey @Planeshifter I have done all the edits which is suggested, it is good for review now |
Progresses #2039.
Description
This pull request:
@stdlib/blas/base/drotmg@stdlib/blas/base/drotmg@stdlib/blas/base/drotmgRelated Issues
This pull request has the following related issues:
Questions
No.
Other
drotmgmain and assign function in C with 6 and 7 arguments respectivelydrotmg.fcode by taking reference from LAPACK LINKChecklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
{{TODO: add disclosure if applicable}}
@stdlib-js/reviewers