-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
test: remove duplicate NaN test cases in normal mean #9588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed duplicate test case for mean function. Signed-off-by: Suyash Pathak <[email protected]>
Removed duplicate test case for mean function. Signed-off-by: Suyash Pathak <[email protected]>
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
Removed duplicate test case for mean function. Signed-off-by: Suyash Pathak <[email protected]>
Removed duplicate test case for mean function. Signed-off-by: Suyash Pathak <[email protected]>
Removed duplicate test case for mean function with specific inputs. Signed-off-by: Suyash Pathak <[email protected]>
Removed duplicate test case for mean function. Signed-off-by: Suyash Pathak <[email protected]>
Removed duplicate test case for mean function with negative input. Signed-off-by: Suyash Pathak <[email protected]>
Removed duplicate test case for mean function with specific inputs. Signed-off-by: Suyash Pathak <[email protected]>
Removed duplicate test case for mean function. Signed-off-by: Suyash Pathak <[email protected]>
Removed duplicate test case for mean function with parameters 2.0 and -1.0. Signed-off-by: Suyash Pathak <[email protected]>
Signed-off-by: Suyash Pathak <[email protected]>
Removed duplicate test case for mean function. Signed-off-by: Suyash Pathak <[email protected]>
Planeshifter
approved these changes
Jan 7, 2026
Contributor
PR Commit MessagePlease review the above commit message and make any necessary adjustments. |
Contributor
Author
|
Thank you @Planeshifter. Looking forward to more contributions! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #9567 .
Description
This pull request: removes exact duplicate test cases in the normal distribution mean tests (
test.jsandtest.native.js) which did not provide additional coverage.The duplicated assertions used identical inputs and expectations for a pure function, making them redundant. Removing them simplifies the test suite while preserving full coverage.
Related Issues
This pull request has the following related issues:
Questions
No.
Other
No.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
{{TODO: add disclosure if applicable}}
@stdlib-js/reviewers