Skip to content

Conversation

@SuYaSh-PaThAk04
Copy link
Contributor

Resolves #9567 .

Description

What is the purpose of this pull request?

This pull request: removes exact duplicate test cases in the normal distribution mean tests (test.js and test.native.js) which did not provide additional coverage.
The duplicated assertions used identical inputs and expectations for a pure function, making them redundant. Removing them simplifies the test suite while preserving full coverage.

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

{{TODO: add disclosure if applicable}}


@stdlib-js/reviewers

Removed duplicate test case for mean function.

Signed-off-by: Suyash Pathak <[email protected]>
Removed duplicate test case for mean function.

Signed-off-by: Suyash Pathak <[email protected]>
@stdlib-bot stdlib-bot added Statistics Issue or pull request related to statistical functionality. Needs Review A pull request which needs code review. labels Jan 6, 2026
@stdlib-bot
Copy link
Contributor

stdlib-bot commented Jan 6, 2026

Coverage Report

Package Statements Branches Functions Lines
stats/base/dists/cosine/mean $\color{green}175/175$
$\color{green}+100.00%$
$\color{green}9/9$
$\color{green}+100.00%$
$\color{green}2/2$
$\color{green}+100.00%$
$\color{green}175/175$
$\color{green}+100.00%$
stats/base/dists/gumbel/mean $\color{green}176/176$
$\color{green}+0.00%$
$\color{green}9/9$
$\color{green}+0.00%$
$\color{green}2/2$
$\color{green}+0.00%$
$\color{green}176/176$
$\color{green}+0.00%$
stats/base/dists/laplace/mean $\color{green}175/175$
$\color{green}+0.00%$
$\color{green}9/9$
$\color{green}+0.00%$
$\color{green}2/2$
$\color{green}+0.00%$
$\color{green}175/175$
$\color{green}+0.00%$
stats/base/dists/levy/mean $\color{green}176/176$
$\color{green}+0.00%$
$\color{green}9/9$
$\color{green}+0.00%$
$\color{green}2/2$
$\color{green}+0.00%$
$\color{green}176/176$
$\color{green}+0.00%$
stats/base/dists/logistic/mean $\color{green}175/175$
$\color{green}+0.00%$
$\color{green}9/9$
$\color{green}+0.00%$
$\color{green}2/2$
$\color{green}+0.00%$
$\color{green}175/175$
$\color{green}+0.00%$
stats/base/dists/lognormal/mean $\color{green}176/176$
$\color{green}+0.00%$
$\color{green}9/9$
$\color{green}+0.00%$
$\color{green}2/2$
$\color{green}+0.00%$
$\color{green}176/176$
$\color{green}+0.00%$
stats/base/dists/normal/mean $\color{green}175/175$
$\color{green}+0.00%$
$\color{green}9/9$
$\color{green}+0.00%$
$\color{green}2/2$
$\color{green}+0.00%$
$\color{green}175/175$
$\color{green}+0.00%$

The above coverage report was generated for the changes in this PR.

Removed duplicate test case for mean function.

Signed-off-by: Suyash Pathak <[email protected]>
Removed duplicate test case for mean function.

Signed-off-by: Suyash Pathak <[email protected]>
Removed duplicate test case for mean function with specific inputs.

Signed-off-by: Suyash Pathak <[email protected]>
Removed duplicate test case for mean function.

Signed-off-by: Suyash Pathak <[email protected]>
Removed duplicate test case for mean function with negative input.

Signed-off-by: Suyash Pathak <[email protected]>
Removed duplicate test case for mean function with specific inputs.

Signed-off-by: Suyash Pathak <[email protected]>
Removed duplicate test case for mean function.

Signed-off-by: Suyash Pathak <[email protected]>
Removed duplicate test case for mean function with parameters 2.0 and -1.0.

Signed-off-by: Suyash Pathak <[email protected]>
Signed-off-by: Suyash Pathak <[email protected]>
Removed duplicate test case for mean function.

Signed-off-by: Suyash Pathak <[email protected]>
@Planeshifter Planeshifter added the Ready To Merge A pull request which is ready to be merged. label Jan 7, 2026
@stdlib-bot stdlib-bot removed the Needs Review A pull request which needs code review. label Jan 7, 2026
@stdlib-bot
Copy link
Contributor

PR Commit Message

test: remove duplicate NaN test cases in normal mean

PR-URL: https://github.com/stdlib-js/stdlib/pull/9588
Closes: https://github.com/stdlib-js/stdlib/issues/9567

Reviewed-by: Philipp Burckhardt <[email protected]>
Signed-off-by: Suyash Pathak <[email protected]>

Please review the above commit message and make any necessary adjustments.

@Planeshifter Planeshifter merged commit a7a77a7 into stdlib-js:develop Jan 7, 2026
29 checks passed
@stdlib-bot stdlib-bot removed the Ready To Merge A pull request which is ready to be merged. label Jan 7, 2026
@SuYaSh-PaThAk04
Copy link
Contributor Author

SuYaSh-PaThAk04 commented Jan 7, 2026

Thank you @Planeshifter. Looking forward to more contributions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Statistics Issue or pull request related to statistical functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[RFC] Duplicate test cases in normal mean package

3 participants