-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
feat!: migrate utils/deep-set to object/deep-set
#9582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: migrate utils/deep-set to object/deep-set
#9582
Conversation
This commit removes the `deepset` symbol from the `@stdlib/utils` namespace due to a package migration. BREAKING CHANGE: remove `deepset` To migrate, users should access the same symbol via the `@stdlib/object` namespace. Ref: stdlib-js#8755
This commit removes `@stdlib/utils/deep-set` in favor of `@stdlib/object/deep-set`. BREAKING CHANGE: remove `utils/deep-set` To migrate, users should update their require/import paths to use `@stdlib/utils/deep-set` which provides the same API and implementation. Ref: stdlib-js#8755
Coverage Report
The above coverage report was generated for the changes in this PR. |
|
@shubham220420 The extra commit updating the variable path should not have been added. All the paths are supposed to be updated in the 2nd commit itself. The reason being it's easier to keep the changelog clean after every major release. |
|
@shubham220420 Neeraj is correct. This PR is invalid. As such, I will go ahead and close. |
yes sir I've read it but since that change was required so I added that commit, |
If it is valid can I open the PR without that extra commit? |
|
@shubham220420 Well, before performing a migration, you could first resolve the lint errors in the The test failures are likely due to you not updating all relevant paths. Note, however, that migrations need to happen sequentially in order to avoid merge conflicts. Hence, only one migration PR can be open at a time. This is another reason why the upstream issue is labeled for maintainers. |
okay sir as you say |
Progresses #8755
Description
This pull request:
utils/deep-settoobject/deep-set.Related Issues
This pull request has the following related issues:
utilspackages toobject(tracking issue) #8755Questions
No.
Other
No.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
{{TODO: add disclosure if applicable}}
@stdlib-js/reviewers