Skip to content

feat!: migrate utils/common-keys to object/common-keys #9379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Neerajpathak07 wants to merge 4 commits into from
Closed

feat!: migrate utils/common-keys to object/common-keys #9379

Neerajpathak07 wants to merge 4 commits into from

Conversation

@Neerajpathak07
Copy link
Member

@Neerajpathak07 Neerajpathak07 commented Dec 26, 2025

Progresses #8755

Description

What is the purpose of this pull request?

This pull request:

  • Migrates utils/common-keys to object/common-keys

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

{{TODO: add disclosure if applicable}}

@stdlib-js/reviewers

@Neerajpathak07
feat: add object/common-keys
d33752e 
Ref: stdlib-js#8755
@Neerajpathak07
remove: remove commonKeys from namespace
f3a9e85 
This commit removes the `commonKeys` symbol from the `@stdlib/utils`
namespace due to a package migration.

BREAKING CHANGE: remove `commonKeys`

To migrate, users should access the same symbol via the
`@stdlib/object` namespace.

Ref: stdlib-js#8755
@Neerajpathak07
refactor: update paths
133ed94 
Ref: stdlib-js#8755
@Neerajpathak07
remove: remove utils/common-keys
9439680 
This commit removes `@stdlib/utils/common-keys` in favor of
`@stdlib/object/common-keys`.

BREAKING CHANGE: remove `utils/common-keys`

To migrate, users should update their require/import paths to use
`@stdlib/object/common-keys` which provides the same API and implementation.

Ref: stdlib-js#8755
@Neerajpathak07
Copy link
Member Author

Neerajpathak07 commented Dec 26, 2025

Closing this amid the CI failures,
One thing that was surprising was that even after adding the first commit for object/common-keys it didn't get added in the object namespace.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Neerajpathak07