feat: add stats/strided/distances/dminkowski

[nakul-krishnakumar]

Resolves None.

Description

What is the purpose of this pull request?

This pull request:

• Adds stats/strided/distances/dminkowski.

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

• None.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

• Read, understood, and followed the contributing guidelines.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

• Yes
• No

If you answered "yes" above, how did you use AI assistance?

• Code generation (e.g., when writing an implementation or fixing a bug)
• Test/benchmark generation
• Documentation (including examples)
• Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

None.

---

@stdlib-js/reviewers

[nakul-krishnakumar]

Please note that the c benchmarks takes longer than other stats/strided/distances implementations as here we benchmark for 4 different values of parameter p.

[stdlib-bot]

Coverage Report

Package	Statements	Branches	Functions	Lines
stats/strided/distances/dminkowski	$\color{green}400/400$ $\color{green}+100.00%$	$\color{green}23/23$ $\color{green}+100.00%$	$\color{green}4/4$ $\color{green}+100.00%$	$\color{green}400/400$ $\color{green}+100.00%$

The above coverage report was generated for the changes in this PR.

[kgryte]

@nakul-krishnakumar Mind resolving the C lint errors?

[nakul-krishnakumar]

@nakul-krishnakumar Mind resolving the C lint errors?

How do you want me to fix the error? Currently it raises error because of the powers array implementation done in the benchmark.length.c

int main( void ) {
	double elapsed;
	double *powers;
	int count;
	int iter;
	int len;
	int i;
	int j;
	int p;

	// Use the current time to seed the random number generator:
	srand( time( NULL ) );

	print_version();
	count = 0;
	powers = (double[]) { 1.0, 2.0, 10.0, INFINITY };
	for ( i = MIN; i <= MAX; i++ ) {
		len = pow( 10, i );
		iter = ITERATIONS / pow( 10, i-1 );
		for ( p = 0; p < 4; p++ ) {
			for ( j = 0; j < REPEATS; j++ ) {
				count += 1;
				printf( "# c::%s:len=%d:p=%.2f\n", NAME, len, powers[ p ] );
				elapsed = benchmark1( iter, len, powers[ p ] );
				print_results( iter, elapsed );
				printf( "ok %d benchmark finished\n", count );
			}
			for ( j = 0; j < REPEATS; j++ ) {
				count += 1;
				printf( "# c::%s:ndarray:len=%d:p=%.2f\n", NAME, len, powers[ p ] );
				elapsed = benchmark2( iter, len, powers[ p ] );
				print_results( iter, elapsed );
				printf( "ok %d benchmark finished\n", count );
			}
		}
	}
	print_summary( count, count );
}

Can I instead do static const double powers[4] = { 1.0, 2.0, 10.0, INFINITY }; ? @kgryte

[kgryte]

What is the point of unrolling the first element? Could you not just initialize d = 0.0 and then have the loop go from i = 0 to i < N? Seems like this is currently just wasting additional characters without a strong motivation.

[nakul-krishnakumar]

What is the point of unrolling the first element? Could you not just initialize d = 0.0 and then have the loop go from i = 0 to i < N? Seems like this is currently just wasting additional characters without a strong motivation.

I was just trying to mimic the implementation of dchebyshev where it is useful as it takes the max of residuals, but here as you said it does look redundant. Thank you for pointing that out. We will have to do the same refactoring for stats/strided/distances/dcityblock too then.

[kgryte]

Suggested change

	p = new Float64Array( [ 1.0, 2.0, 10.0, Infinity ] );
	p = new Float64Array( [ 1.0, 2.0, 10.0, PINF ] );

Use the stdlib constant.

[kgryte]

Use the stdlib constant.

Suggested change

	p = new Float64Array( [ 1.0, 2.0, 10.0, Infinity ] );
	p = new Float64Array( [ 1.0, 2.0, 10.0, PINF ] );

[kgryte]

Suggested change

	p = new Float64Array( [ 1.0, 2.0, 10.0, Infinity ] );
	p = new Float64Array( [ 1.0, 2.0, 10.0, PINF ] );

[kgryte]

Suggested change

	p = new Float64Array( [ 1.0, 2.0, 10.0, Infinity ] );
	p = new Float64Array( [ 1.0, 2.0, 10.0, PINF ] );

[kgryte]

If we really want to be pedantic, you can also use the stdlib constant here, as well.

[kgryte]

Other than the use of PINF, this PR is looking good.