[6.x] Collapse empty publish sections #13379
Closed
+7
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I thought about adding this rule globally but it's possible that data is loading in dynamically such as the grid view on /cp/collections, which loads in entries after the page has initiated—so in this case it would flip-flop between an empty/not empty state. So it's probably best to scope this selector.
Member
|
This didn't seem to have any effect for me. I still saw the extra space. Replacing with #13381 anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR collapses the publish section margin when it has no fields. It closes #13373
A CSS solution was simpler here than a Vue one.
P.S. I thought about adding this CSS rule globally, but data may be loading in dynamically such as the grid view on /cp/collections, which loads in entries after the page has initiated—so in this case it would flip-flop between an empty/not empty state. So it's probably best to scope this selector.