Support Workload Identity Federation flow#1109
Open
JorTurFer wants to merge 29 commits intostackitcloud:mainfrom
Open
Support Workload Identity Federation flow#1109JorTurFer wants to merge 29 commits intostackitcloud:mainfrom
JorTurFer wants to merge 29 commits intostackitcloud:mainfrom
Conversation
marceljk
reviewed
Jan 13, 2026
Comment on lines
+530
to
+557
| if sdkConfig.ServiceAccountFederatedTokenFunc == nil && getEnvBoolIfValueAbsent(providerConfig.UseOIDC, "STACKIT_USE_OIDC") { | ||
| sdkConfig.WorkloadIdentityFederation = true | ||
| // https://docs.github.com/en/actions/reference/security/oidc#methods-for-requesting-the-oidc-token | ||
| oidcReqURL := getEnvStringOrDefault(providerConfig.OIDCTokenRequestURL, "ACTIONS_ID_TOKEN_REQUEST_URL", "") | ||
| oidcReqToken := getEnvStringOrDefault(providerConfig.OIDCTokenRequestToken, "ACTIONS_ID_TOKEN_REQUEST_TOKEN", "") | ||
| if oidcReqURL != "" && oidcReqToken != "" { | ||
| sdkConfig.ServiceAccountFederatedTokenFunc = oidcadapters.RequestGHOIDCToken(oidcReqURL, oidcReqToken) | ||
| } |
Contributor
There was a problem hiding this comment.
Is this implementation Github specific? If yes, I think the env STACKIT_USE_OIDC could be confusing, because it sounds more generic, but it enables only OIDC for Github.
Contributor
Author
There was a problem hiding this comment.
This is Github specific but next step is to support AzDO too (I'm on it but it required a task on AzDO). I've used a generic name because of that, but I can change it if you prefer.
Contributor
Author
There was a problem hiding this comment.
Also, there is an option to provide the OIDC token by your own, so I'd not change this
|
This PR was marked as stale after 7 days of inactivity and will be closed after another 7 days of further inactivity. If this PR should be kept open, just add a comment, remove the stale label or push new commits to it. |
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
Co-authored-by: Marcel Jacek <72880145+marceljk@users.noreply.github.com>
Signed-off-by: Jorge Turrado <jorge.turrado@mail.schwarz>
JorTurFer
force-pushed
the
prepare-wif
branch
from
4ad56b1 to
dadceb9
Compare
Signed-off-by: Jorge Turrado <jorge.turrado@mail.schwarz>
Signed-off-by: Jorge Turrado <jorge.turrado@mail.schwarz>
Signed-off-by: Jorge Turrado <jorge.turrado@mail.schwarz>
JorTurFer
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Aligned with the incoming workload identity federation feature, this PR support workload identity federation flow
This PR from the SDK is needed -> stackitcloud/stackit-sdk-go#4074
Checklist
make fmtexamples/directory)make generate-docs(will be checked by CI)make test(will be checked by CI)make lint(will be checked by CI)