Onboarding Intake(1/3): Intake Runner by devanshcache · Pull Request #1086 · stackitcloud/terraform-provider-stackit

devanshcache · 2025-12-08T08:08:19Z

Description

This PR onboards the new STACKIT Intake (ticket) service into the Terraform provider.

Intake is composed of three components:

Intake Runners: dedicated, isolated runtime data ingestion environment
Intake: a specific data stream or topic within an Intake Runner
Intake Users: provides secure access credentials for your applications to connect to your Intake

This PR contains the Intake Runners part only to make a quicker and less overwhelming review.

Checklist

Issue was linked above
Code format was applied: make fmt
Examples were added / adjusted (see examples/ directory)
Docs are up-to-date: make generate-docs (will be checked by CI)
Unit tests got implemented or updated
Acceptance tests got implemented or updated (see e.g. here)
Unit tests are passing: make test (will be checked by CI)
No linter issues: make lint (will be checked by CI)

stackit/internal/services/intake/runner/resource.go

rubenhoenle · 2026-01-22T08:57:46Z

stackit/internal/services/intake/runner/resource_acc_test.go

@@ -0,0 +1,160 @@
+package runner_test


Could you move this file please to stackit/internal/services/intake/intake_acc_test.go please?

We have one acc test for each service usually. See https://github.com/stackitcloud/terraform-provider-stackit/blob/da2bb41b1e1c702e8aa53ae5221f5a49bd6a9251/stackit/internal/services/git/git_acc_test.go for reference 😅

rubenhoenle · 2026-01-22T08:58:26Z

stackit/internal/services/intake/runner/resource_acc_test.go

+}
+
+func testAccIntakeRunnerConfigFull(name, description string, maxKib, maxPerHour int) string {
+	return fmt.Sprintf(`


Please specify the test config as a terraform file and embed it into the test like we have it in most places:

terraform-provider-stackit/stackit/internal/services/git/git_acc_test.go

Lines 22 to 26 in da2bb41

//go:embed testdata/resource-min.tf

var resourceMin string

//go:embed testdata/resource-max.tf

var resourceMax string

You can then specify your test variables like that:

terraform-provider-stackit/stackit/internal/services/git/git_acc_test.go

Lines 34 to 44 in da2bb41

var testConfigVarsMin = config.Variables{

"project_id": config.StringVariable(testutil.ProjectId),

"name": config.StringVariable(nameMin),

}

var testConfigVarsMax = config.Variables{

"project_id": config.StringVariable(testutil.ProjectId),

"name": config.StringVariable(nameMax),

"acl": config.StringVariable("192.168.0.0/16"),

"flavor": config.StringVariable("git-100"),

}

rubenhoenle · 2026-01-22T08:59:37Z

stackit/internal/services/intake/runner/resource_acc_test.go

+					resource.TestCheckResourceAttr(intakeRunnerResource, "description", ""),
+					resource.TestCheckResourceAttr(intakeRunnerResource, "labels.%", "0"),
+				),
+			},


Please also test the datasource within your acc test, see

terraform-provider-stackit/stackit/internal/services/git/git_acc_test.go

Lines 87 to 137 in da2bb41

// Data source

{

ConfigVariables: testConfigVarsMin,

Config: fmt.Sprintf(`

%s

data "stackit_git" "git" {

project_id = stackit_git.git.project_id

instance_id = stackit_git.git.instance_id

}

`, testutil.GitProviderConfig()+resourceMin,

),

Check: resource.ComposeAggregateTestCheckFunc(

// Instance

resource.TestCheckResourceAttr("data.stackit_git.git", "project_id", testutil.ConvertConfigVariable(testConfigVarsMin["project_id"])),

resource.TestCheckResourceAttrPair(

"stackit_git.git", "project_id",

"data.stackit_git.git", "project_id",

),

resource.TestCheckResourceAttrPair(

"stackit_git.git", "instance_id",

"data.stackit_git.git", "instance_id",

),

resource.TestCheckResourceAttrPair(

"stackit_git.git", "name",

"data.stackit_git.git", "name",

),

resource.TestCheckResourceAttrPair(

"stackit_git.git", "url",

"data.stackit_git.git", "url",

),

resource.TestCheckResourceAttrPair(

"stackit_git.git", "version",

"data.stackit_git.git", "version",

),

resource.TestCheckResourceAttrPair(

"stackit_git.git", "created",

"data.stackit_git.git", "created",

),

resource.TestCheckResourceAttrPair(

"stackit_git.git", "consumed_object_storage",

"data.stackit_git.git", "consumed_object_storage",

),

resource.TestCheckResourceAttrPair(

"stackit_git.git", "consumed_disk",

"data.stackit_git.git", "consumed_disk",

),

resource.TestCheckResourceAttrPair(

"stackit_git.git", "flavor",

"data.stackit_git.git", "flavor",

),

for reference

rubenhoenle · 2026-01-22T09:00:23Z

docs/resources/intake_runner.md

@@ -0,0 +1,34 @@
+---
+# generated by https://github.com/hashicorp/terraform-plugin-docs
+page_title: "stackit_intake_runner Resource - stackit"


docs and examples for the datasource are missing

stackit/internal/services/intake/runner/data_source.go

rubenhoenle · 2026-01-22T09:46:36Z

stackit/internal/services/intake/runner/resource.go

+					stringplanmodifier.RequiresReplace(),
+				},
+				Validators: []validator.String{
+					stringvalidator.OneOf("eu01"), // Currently Intake supports only EU01 region


This won't prevent the default_region in the provider configuration to not be eu02 😉

rubenhoenle · 2026-01-22T09:48:22Z

stackit/internal/services/intake/runner/resource.go

+		model.Labels = labels
+	}
+
+	if runnerResp.Id != nil && *runnerResp.Id == "" {


Suggested change

if runnerResp.Id != nil && *runnerResp.Id == "" {

if runnerResp.Id != nil || *runnerResp.Id == "" {

Switched to:

if runnerResp.Id == nil || *runnerResp.Id == "" {

rubenhoenle · 2026-01-22T09:49:07Z

stackit/internal/services/intake/runner/resource.go

+	}
+	model.Name = types.StringPointerValue(runnerResp.DisplayName)
+	if runnerResp.Description == nil {
+		model.Description = types.StringValue("")


This whole condition shouldn't be needed. The following line should be enough

model.Description = types.StringPointerValue(runnerResp.Description)

rubenhoenle · 2026-01-22T09:49:48Z

stackit/internal/services/intake/runner/resource.go

+	return nil
+}
+
+// Build CreateBarPayload from provider's model


Suggested change

// Build CreateBarPayload from provider's model

// Build CreateIntakeRunnerPayload from provider's model

either adjust the example comments from the contribution guide or remove them 😅

rubenhoenle · 2026-01-22T09:51:05Z

stackit/internal/services/intake/runner/resource.go

+	// Handle optional fields
+	if !model.Description.IsUnknown() || model.Description.IsNull() {
+		if model.Description.IsNull() {
+			payload.Description = sdkUtils.Ptr("")


What's the point of this? Sending an empty string? Just leave it out of the payload, it's optional 😄

rubenhoenle · 2026-01-22T09:51:56Z

stackit/internal/services/intake/runner/resource.go

+
+	payload := &intake.UpdateIntakeRunnerPayload{}
+
+	if !model.Name.IsUnknown() {


Suggested change

if !model.Name.IsUnknown() {

I would leave this out. Display name is marked as required for the create request, you'll always have to send it.

rubenhoenle · 2026-01-22T09:52:06Z

stackit/internal/services/intake/runner/resource.go

+		payload.DisplayName = conversion.StringValueToPointer(model.Name)
+	}
+
+	if !model.MaxMessageSizeKiB.IsUnknown() {


rubenhoenle · 2026-01-22T09:52:11Z

stackit/internal/services/intake/runner/resource.go

+		payload.MaxMessageSizeKiB = conversion.Int64ValueToPointer(model.MaxMessageSizeKiB)
+	}
+
+	if !model.MaxMessagesPerHour.IsUnknown() {


rubenhoenle · 2026-01-22T09:52:45Z

stackit/internal/services/intake/runner/resource.go

+	if !model.Labels.IsUnknown() {
+		if model.Labels.IsNull() {
+			labels = map[string]string{}
+			payload.Labels = &labels


labels are optional, just leave them out of the payload...

rubenhoenle · 2026-01-22T09:54:27Z

stackit/provider.go

 			},
+			"intake_custom_endpoint": schema.StringAttribute{
+				Optional:    true,
+				Description: descriptions["intake_custom_endpoint"],


You will have to add your description to the descriptions slice...

rubenhoenle · 2026-01-22T09:56:01Z

stackit/internal/services/intake/runner/data_source.go

+			},
+			"region": schema.StringAttribute{
+				Description: descriptions["region"],
+				Required:    true,


Why is the region required? It should use the default_region value from the provider configuration as a fallback value, just as all our datasource implementations do.

resolved I believe

rubenhoenle · 2026-01-22T09:57:49Z

stackit/internal/services/intake/runner/resource_acc_test.go

+		// Try to find the runner
+		_, err := client.GetIntakeRunner(ctx, rs.Primary.Attributes["project_id"], rs.Primary.Attributes["region"], rs.Primary.Attributes["runner_id"]).Execute()
+		if err == nil {
+			return fmt.Errorf("intake runner with ID %s still exists", rs.Primary.ID)


If it still exists, delete it 😉

terraform-provider-stackit/stackit/internal/services/git/git_acc_test.go

Line 335 in da2bb41

err := client.DeleteInstance(ctx, testutil.ProjectId, *gitInstances[i].Id).Execute()

rubenhoenle · 2026-01-22T09:59:18Z

stackit/internal/services/intake/runner/resource_acc_test.go

+	var err error
+	if testutil.IntakeCustomEndpoint == "" {
+		client, err = intake.NewAPIClient(
+			sdkConfig.WithRegion("eu01"),


Suggested change

sdkConfig.WithRegion("eu01"),

This shouldn't be needed. It's only needed because you have two region parameters in your API URLs:

https://intake.api.eu01.stackit.cloud/v1beta/projects/{projectId}/regions/{regionId}/intake-runners

One in the hostname and one in the URL path. The one in the hostname is redundant and shouldn't be there 😅

rubenhoenle · 2026-01-26T09:45:30Z

@yago-123 could you please resolve the comments you adressed already? I will only start with another review as soon as all open comments are resolved.

rubenhoenle · 2026-01-26T09:51:21Z

And please check that failing CI pipeline. Maybe run a make lint and a make test before your next update of this PR 😅

yago-123 · 2026-01-26T10:02:51Z

@yago-123 could you please resolve the comments you adressed already? I will only start with another review as soon as all open comments are resolved.

Yes! notice this is still in progress though

yago-123 · 2026-01-27T14:57:05Z

@rubenhoenle this is ready to be reviewed 🫡

rubenhoenle · 2026-01-28T08:38:01Z

@yago-123 CI pipeline is failing

# Conflicts: # go.mod # go.sum # stackit/internal/testutil/testutil.go # stackit/provider.go # Conflicts: # stackit/internal/testutil/testutil.go

# Conflicts: # go.sum # Conflicts: # go.mod # go.sum

Co-authored-by: Ruben Hönle <git@hoenle.xyz>

…erly

yago-123 · 2026-01-30T08:57:52Z

@yago-123 CI pipeline is failing

@rubenhoenle this should be ready now

github-actions · 2026-02-07T03:35:12Z

This PR was marked as stale after 7 days of inactivity and will be closed after another 7 days of further inactivity. If this PR should be kept open, just add a comment, remove the stale label or push new commits to it.

devanshcache requested a review from a team as a code owner December 8, 2025 08:08

devanshcache changed the title ~~onboarding(1/3): Intake Runner~~ Onboarding Intake(1/3): Intake Runner Dec 8, 2025

rubenhoenle reviewed Dec 12, 2025

View reviewed changes

stackit/internal/services/intake/runner/resource.go Show resolved Hide resolved

marceljk added the ignore-stale label Dec 19, 2025

rubenhoenle removed the ignore-stale label Jan 19, 2026

rubenhoenle reviewed Jan 22, 2026

View reviewed changes

stackit/internal/services/intake/runner/data_source.go Outdated Show resolved Hide resolved

rubenhoenle reviewed Jan 22, 2026

View reviewed changes

yago-123 force-pushed the onboard-intake branch from 89b2fc8 to 540b360 Compare January 22, 2026 10:25

yago-123 force-pushed the onboard-intake branch 3 times, most recently from 9d5b54d to 3922287 Compare January 27, 2026 14:54

yago-123 force-pushed the onboard-intake branch from 3922287 to a2fdb55 Compare January 28, 2026 09:29

Devansh Thakur and others added 21 commits January 29, 2026 09:44

Resolve conflicts

1968867

# Conflicts: # go.mod # go.sum # stackit/internal/testutil/testutil.go # stackit/provider.go # Conflicts: # stackit/internal/testutil/testutil.go

added example of intake runner

3c69a1e

added datasource for intake runner

31f6ff6

Resolve conflicts

598a23b

# Conflicts: # go.sum # Conflicts: # go.mod # go.sum

Add docs

28d29ee

Update stackit/internal/services/intake/runner/data_source.go

cdbab50

Co-authored-by: Ruben Hönle <git@hoenle.xyz>

Remove region field

25c8d02

Add description to custom endpoint

3c42157

Adjust fields for resource.go (still missing region)

2bda5e9

Reintroduce region as optional field in data resource

13464da

Adjust resource implementation and implement review comments

d96f537

Reshape resource_acc_test

6582dec

Remove replace directive during name change & complement test checks

27b7f29

docs

50c02d6

lint

002ee74

Adjust resource_test

f4b4755

adjust last small tweaks

37459c4

lint

528ec74

Add missing checks in tests

860b2b0

Fix remaining test failing in resource_test.go

b28b8c2

Adjust destroy function

e00faf5

yago-123 force-pushed the onboard-intake branch from a2fdb55 to e00faf5 Compare January 29, 2026 08:46

Yago Carlos Fernandez Gou added 2 commits January 29, 2026 09:47

Adjust go.mod

a36b04c

Reestablish tf-plugin-docs to newer version and re-generate docs prop…

4b47444

…erly

github-actions bot added the Stale PR is marked as stale due to inactivity. label Feb 7, 2026

	//go:embed testdata/resource-min.tf
	var resourceMin string

	//go:embed testdata/resource-max.tf
	var resourceMax string

	var testConfigVarsMin = config.Variables{
	"project_id": config.StringVariable(testutil.ProjectId),
	"name": config.StringVariable(nameMin),
	}

	var testConfigVarsMax = config.Variables{
	"project_id": config.StringVariable(testutil.ProjectId),
	"name": config.StringVariable(nameMax),
	"acl": config.StringVariable("192.168.0.0/16"),
	"flavor": config.StringVariable("git-100"),
	}

	// Data source
	{
	ConfigVariables: testConfigVarsMin,
	Config: fmt.Sprintf(`
	%s

	data "stackit_git" "git" {
	project_id = stackit_git.git.project_id
	instance_id = stackit_git.git.instance_id
	}
	`, testutil.GitProviderConfig()+resourceMin,
	),
	Check: resource.ComposeAggregateTestCheckFunc(
	// Instance
	resource.TestCheckResourceAttr("data.stackit_git.git", "project_id", testutil.ConvertConfigVariable(testConfigVarsMin["project_id"])),
	resource.TestCheckResourceAttrPair(
	"stackit_git.git", "project_id",
	"data.stackit_git.git", "project_id",
	),
	resource.TestCheckResourceAttrPair(
	"stackit_git.git", "instance_id",
	"data.stackit_git.git", "instance_id",
	),
	resource.TestCheckResourceAttrPair(
	"stackit_git.git", "name",
	"data.stackit_git.git", "name",
	),
	resource.TestCheckResourceAttrPair(
	"stackit_git.git", "url",
	"data.stackit_git.git", "url",
	),
	resource.TestCheckResourceAttrPair(
	"stackit_git.git", "version",
	"data.stackit_git.git", "version",
	),
	resource.TestCheckResourceAttrPair(
	"stackit_git.git", "created",
	"data.stackit_git.git", "created",
	),
	resource.TestCheckResourceAttrPair(
	"stackit_git.git", "consumed_object_storage",
	"data.stackit_git.git", "consumed_object_storage",
	),
	resource.TestCheckResourceAttrPair(
	"stackit_git.git", "consumed_disk",
	"data.stackit_git.git", "consumed_disk",
	),
	resource.TestCheckResourceAttrPair(
	"stackit_git.git", "flavor",
	"data.stackit_git.git", "flavor",
	),

	if runnerResp.Id != nil && *runnerResp.Id == "" {
	if runnerResp.Id != nil \|\| *runnerResp.Id == "" {

	// Build CreateBarPayload from provider's model
	// Build CreateIntakeRunnerPayload from provider's model


		payload := &intake.UpdateIntakeRunnerPayload{}

		if !model.Name.IsUnknown() {

Conversation

devanshcache commented Dec 8, 2025

Description

Checklist

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rubenhoenle Jan 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rubenhoenle commented Jan 26, 2026

rubenhoenle Jan 22, 2026 •

edited

Loading