enable v3 app ssh via UI for web: type process #91
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nouseforaname
force-pushed
the
feature_v3_rolling_app_ssh
branch
from
23c50c4 to
67f872f
Compare
gogolok
reviewed
Aug 28, 2025
gogolok
reviewed
Aug 28, 2025
gogolok
reviewed
Aug 28, 2025
nouseforaname
force-pushed
the
feature_v3_rolling_app_ssh
branch
from
5eadc1a to
37743a4
Compare
stackit-cloudfoundry
force-pushed
the
feature_v3_rolling_app_ssh
branch
from
b2b6921 to
94733de
Compare
currently the UI fails establishing an ssh connection to apps that rely on cc v3 functionality. Some basic apps ( e.g. `cf push test -b staticfile_buildpack` seems to produce an app that the UI can still ssh into ) still work but anything that relies on v3 functionality ( e.g. multi process apps or `cf push --strategy rolling` ) will fail. The default type for a process of a pushed app is `web`. This commit enables using the UI to ssh to the default web process of V3 apps. It left out adding support for all other process types since the UI misses the feature to select nested processes. It only displays the `instances` that an app has running but none of the nested elements of V3 apps. we only want to ignore 404 errors when checking for v3 availability. other errors may still provide relevant information. some auth related code was extracted from getSSHCode so it's reusable in CheckForV3... in the same reasoning requesting the token and refreshing it was moved up.
- remove unneeded struct - remove newline - go fmt
nouseforaname
force-pushed
the
feature_v3_rolling_app_ssh
branch
from
94733de to
f20d427
Compare
patzeltj
approved these changes
Sep 1, 2025
gogolok
reviewed
Sep 8, 2025
gogolok
reviewed
Sep 8, 2025
camel case is not expected here
it should improve readability
if something goes wrong, that will at least leave a hint in the logs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently the UI fails establishing an ssh connection to apps that rely on cc v3 functionality. Some basic apps ( e.g.
cf push test -b staticfile_buildpackseems to produce an app that the UI can still ssh into ) still work but anything that relies on v3 functionality ( e.g. multi process apps orcf push --strategy rolling) will fail.The default type for a process of a pushed app is
web. This commit enables using the UI to ssh to the default web process of V3 apps. It left out adding support for all other process types since the UI misses the feature to select nested processes. It only displays theinstancesthat an app has running but none of the nested elements of V3 apps.