-
Notifications
You must be signed in to change notification settings - Fork 7
refactor: composite retriever and make reranker optional #144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and libraries; enhance tracing in TracedRunnable to include input and output in span updates.
…uster setup script with ingress-nginx installation
Co-authored-by: Copilot <[email protected]>
…t installation process
…late into fix/bitnami-issues
…pruning capabilities
…nts and enable reranker
robodev-r2d2
approved these changes
Dec 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements and refactors to the retriever and reranker configuration, document retrieval logic, and related documentation. The main focus is on making settings more explicit and robust, optimizing retrieval performance, and improving summary/document handling.
Configuration and Settings Refactor:
RETRIEVER_TOTAL_K_DOCUMENTS, replacing legacy environment variable names and ensuring backward compatibility. This change is reflected in both the code (RetrieverSettings) and configuration files (values.yaml,README.md). [1] [2] [3] [4] [5]Retriever and Reranker Logic Improvements:
CompositeRetrieverto:asyncio.gatherfor significant latency reduction.User Experience and Documentation:
Summary of Most Important Changes:
Configuration and Settings:
RETRIEVER_TOTAL_K_DOCUMENTS, deprecating legacy names and updating all relevant configs and documentation. [1] [2] [3] [4] [5]min_relevance_scoreandenabledfields to reranker settings, with corresponding config support. [1] [2] [3]Retriever and Reranker Logic:
CompositeRetrieverto use concurrent retrieval, more efficient duplicate filtering, summary document expansion, and robust reranker invocation with new settings. [1] [2] [3] [4] [5]User Experience: