fix(template/helm): Add checksum/config annotation#480
Merged
NickLarsenNZ merged 1 commit intomainfrom Feb 3, 2025
Merged
Conversation
Add the dynamic `checksum/config` annotation back in.
Previously, this annotation only appeared when `.Values.podAnnotations` was set.
It was only discovered broken by adding podAnnotations and seeing that the `include` context was invalid, leading to this error:
```
Error: template: trino-operator/templates/deployment.yaml:20:28: executing "trino-operator/templates/deployment.yaml" at <include (print $.Template.BasePath "/configmap.yaml") .>: error calling include: template: trino-operator/templates/configmap.yaml:4:10: executing "trino-operator/templates/configmap.yaml" at <.Files.Glob>: nil pointer evaluating interface {}.Glob
```
Note, this was always broken since inception in #7.
NickLarsenNZ
added
scheduled-for/25.3.0
release-note/action-required
Member
Author
Release NoteOperators deployed by Helm will contain an extra pod annotation: |
NickLarsenNZ
commented
Jan 30, 2025
Techassi
approved these changes
Feb 3, 2025
Member
Techassi
left a comment
Techassi
left a comment
There was a problem hiding this comment.
Approved as is.
I don't have any strong opinions on namespacing the checksum field.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the dynamic
checksum/configannotation back in.This is supposed to be used for rolling out the Deployment when the ConfigMap content changes.
Previously, this annotation only appeared when
.Values.podAnnotationswas set.It was only discovered broken by adding podAnnotations and seeing that the
includecontext was invalid, leading to this error:Note, this was always broken since inception in #7.