This repository was archived by the owner on Jan 24, 2024. It is now read-only.
Use progressr with future framework for progress updates #703
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes how some functions deal with sequential and parallel processes.
Following the suggestion in #424 and discussion in #140 regarding the missing
future.seedsetting, I dropped the detection of number of cores and theifelseswitch betweenpbapply::pbsapplyandfuture.apply::future_sapplyfor sequential and parallel computing respectively, and opted to use theprogressrpackage for progress updates. The package came installed withCellChat, so there is no need to install additional dependencies.I also:
multiprocessin thenetClusteringfunction (similar PRs: changed plan("multiprocess") to plan("multisession") for the netClustering call #574 and adjusted line future to new multisession #682) and replace it with eithermultisessionormulticoredepending on the detected OS type (multicoreis significant faster thanmultisessionin the Linux environment that I am using).Pboot(default with 100 permutations) in thecomputeCommunProbfunction, which was running sequentially before. The update should significantly speed upcomputeCommunProb().