SimpleAliasRegistry: extend test cases + small fix around alias overriding #36021
+115
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, here is a Pull Request that:
SimpleAliasRegistryTeststo cover theallowAliasOverridingfunctionality.SimpleAliasRegistry(explanation below).Old behaviour was:
To my opinion, this should only be allowed if
allowAliasOverriding = true, in exactly the same way as the existing implementation would only allow registering alias [A -> C] ifallowAliasOverriding = true.New behaviour:
allowAliasOverriding = trueBehaviour covered the following test cases in this PR:
SimpleAliasRegistryTests.registerAliasWithSameName_GivenAliasOverridingAllowed_ThenReplacesExistingAliasSimpleAliasRegistryTests.registerAliasWithSameName_GivenAliasOverridingNotAllowed_ThenThrowsExceptionThank you for the review, and have a nice day.