Skip to content

Conversation

@vincentstradiot
Copy link

@vincentstradiot vincentstradiot commented Dec 13, 2025

Hi, here is a Pull Request that extends and improves some test cases.

  • In the CollectionUtilsTest:
    • It seems important to me to run each case/assert with a fresh enumeration. Otherwise, the test cases are not independent as we might already have enumerated some elements in case 1 when running case 2.
    • I also added the case where the element is not found.
  • In the ExponentialBackOffTests I added tests for a functionality that was not covered (jitter).
  • In BooleanComparatorTests I extended the existing test cases to be more exhaustive.

Thank you for the review, and have a nice day.

CollectionUtilsTests:
   - Every case must be run with a fresh enumeration
   - Extend test cases with non-existing element
ExponentialBackOffTests:
   - Rename test case to better reflect what it does
   - Extend test case with jitter functionality
BooleanComparatorTests:
   - Extend test cases to be more exhaustive

Signed-off-by: Vincent Stradiot <[email protected]>
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Dec 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: waiting-for-triage An issue we've not yet triaged or decided on

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants