feat(oauth): Add refresh to oauthdevice.Client#1227
Merged
burmudar merged 3 commits intowb/add-oauth-device-flowfrom Mar 9, 2026
Merged
feat(oauth): Add refresh to oauthdevice.Client#1227burmudar merged 3 commits intowb/add-oauth-device-flowfrom
burmudar merged 3 commits intowb/add-oauth-device-flowfrom
Conversation
Contributor
Author
|
This change is part of the following stack: Change managed by git-spice. |
This was referenced Dec 8, 2025
Merged
keegancsmith
reviewed
Dec 8, 2025
Member
keegancsmith
left a comment
keegancsmith
left a comment
There was a problem hiding this comment.
did you test what happens if someone revokes src-cli and then you try refresh a token / use an old token? I'm interested to know if the error message you show users is possible to debug as that being the issue.
Contributor
Author
Noopee! Def a good call out - I'll make sure to test it |
burmudar
force-pushed
the
wb/add-oauth-device-flow
branch
from
fd1668e to
1565618
Compare
burmudar
force-pushed
the
wb/add-oauth-refresh-token
branch
from
2f24f44 to
7f2c665
Compare
burmudar
force-pushed
the
wb/add-oauth-device-flow
branch
from
1565618 to
9a04958
Compare
burmudar
force-pushed
the
wb/add-oauth-refresh-token
branch
from
7f2c665 to
87b5732
Compare
burmudar
force-pushed
the
wb/add-oauth-device-flow
branch
from
9a04958 to
c1c82ec
Compare
burmudar
force-pushed
the
wb/add-oauth-refresh-token
branch
from
87b5732 to
abd0850
Compare
Contributor
Author
Tried the above scenario and the only error we get back is "Invalid OAuth Token". We catch it in #1228 and then guide the user to re-run |
keegancsmith
approved these changes
Mar 2, 2026
burmudar
force-pushed
the
wb/add-oauth-device-flow
branch
from
c1c82ec to
61a1070
Compare
burmudar
force-pushed
the
wb/add-oauth-refresh-token
branch
from
abd0850 to
f79c981
Compare
* add refresh to oauthdevice.Client * add OAuth Transport and use it if no access token * secrets: switch to zalando/go-keyring and add context support * secrets: scope keyring by endpoint
burmudar
added a commit
that referenced
this pull request
Mar 9, 2026
…Auth client (#1223) * removed unused func * add refresh token to device response unmarshall * make NewClient take ClientID as param * add oauth flow and use oauth token when SRC_ACCESS_TOKEN is empty * feat(oauth): Add refresh to oauthdevice.Client (#1227) * add refresh to oauthdevice.Client * oauthdevice: add RefreshToken field and Refresh method * feat(oauth): Use keyring to store oauth token (#1228) * add refresh to oauthdevice.Client * add OAuth Transport and use it if no access token * secrets: switch to zalando/go-keyring and add context support * secrets: scope keyring by endpoint
burmudar
added a commit
that referenced
this pull request
Mar 23, 2026
…Auth client (#1223) * removed unused func * add refresh token to device response unmarshall * make NewClient take ClientID as param * add oauth flow and use oauth token when SRC_ACCESS_TOKEN is empty * feat(oauth): Add refresh to oauthdevice.Client (#1227) * add refresh to oauthdevice.Client * oauthdevice: add RefreshToken field and Refresh method * feat(oauth): Use keyring to store oauth token (#1228) * add refresh to oauthdevice.Client * add OAuth Transport and use it if no access token * secrets: switch to zalando/go-keyring and add context support * secrets: scope keyring by endpoint (cherry picked from commit 0bc535e)
burmudar
added a commit
that referenced
this pull request
Mar 23, 2026
…Auth client (#1223) * removed unused func * add refresh token to device response unmarshall * make NewClient take ClientID as param * add oauth flow and use oauth token when SRC_ACCESS_TOKEN is empty * feat(oauth): Add refresh to oauthdevice.Client (#1227) * add refresh to oauthdevice.Client * oauthdevice: add RefreshToken field and Refresh method * feat(oauth): Use keyring to store oauth token (#1228) * add refresh to oauthdevice.Client * add OAuth Transport and use it if no access token * secrets: switch to zalando/go-keyring and add context support * secrets: scope keyring by endpoint (cherry picked from commit 0bc535e)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add refresh to oauthdevice.Client
oauthdevice: add RefreshToken field and Refresh method
Test plan