Open
Conversation
d30525e to
4a97a8e
Compare
77372d7 to
3e2ba37
Compare
a22f054 to
8db0cc2
Compare
| @@ -12,7 +12,7 @@ | |||
| }, | |||
| "dependencies": { | |||
| "@actions/artifact": "^6.0.0", | |||
There was a problem hiding this comment.
Bug: A deep import from @actions/core/lib/summary.js will fail at runtime because v3.0.0 of the package is ESM-only and does not export this internal path.
Severity: CRITICAL
Suggested Fix
Update the import statement to use the main package entry point, which is a supported public API. Change the import from import type { SummaryTableRow } from '@actions/core/lib/summary.js'; to import type { SummaryTableRow } from '@actions/core';.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: .github/actions/package.json#L14
Potential issue: The code imports a type using a deep path: `import type {
SummaryTableRow } from '@actions/core/lib/summary.js';`. While this compiles
successfully due to the `"moduleResolution": "bundler"` setting, it will cause a runtime
failure. The build configuration marks `@actions/core` as an external package, so the
import is resolved by Node.js when the action runs. The updated v3.0.0 of
`@actions/core` is ESM-only and does not expose this internal path in its `package.json`
exports map. This will result in an `ERR_PACKAGE_PATH_NOT_EXPORTED` error, causing the
GitHub Action to crash on startup.
Did we get this right? 👍 / 👎 to inform future reviews.
defc4e1 to
5e7e3ec
Compare
5e7e3ec to
ae0dfb9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
^1.11.1→^3.0.0Release Notes
actions/toolkit (@actions/core)
v3.0.0import()instead ofrequire()v2.0.3@actions/http-clientto3.0.2v2.0.1v2.0.0Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.