Skip to content

[docs] Buttons#3968

Merged
m-bert merged 9 commits intomainfrom
@mbert/docs-buttons
Feb 17, 2026
Merged

[docs] Buttons#3968
m-bert merged 9 commits intomainfrom
@mbert/docs-buttons

Conversation

@m-bert
Copy link
Contributor

@m-bert m-bert commented Feb 9, 2026

Description

This PR updates Buttons entry in docs.

Test plan

Read docs 🤓

Copilot AI review requested due to automatic review settings February 9, 2026 13:18
@m-bert m-bert changed the title @mbert/docs buttons [docs] Buttons Feb 9, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates Gesture Handler 3 migration and documentation content around button components, including a rewrite of the Buttons docs page and additional notes in the GH3 upgrade guide.

Changes:

  • Reworked buttons.mdx content/structure (added RawButton, reorganized props, moved accessibility section).
  • Updated “Upgrading to 3” guide and migration skill docs with notes about legacy buttons / PureNativeButton.
  • Minor formatting adjustments (spacing) in the GH3 migration skill doc.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.

File Description
skills/gesture-handler-3-migration/SKILL.md Adds migration guidance around buttons and mentions PureNativeButton.
packages/docs-gesture-handler/docs/guides/upgrading-to-3.mdx Updates upgrade guidance and legacy buttons mapping table.
packages/docs-gesture-handler/docs/components/buttons.mdx Major rewrite/restructure of the Buttons documentation page.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@m-bert m-bert marked this pull request as ready for review February 10, 2026 08:18
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably want to suggest possible solutions it can propose to the user

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it depends on their use case. Using PureNativeButton should be rare case anyway and I'm not sure if simply saying "change it to RawButton" will work, as it has Native gesture pre-applied. So I'm not sure if there's a panacea for that specific case. cc @j-piasecki

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure there is a clear migration path here - I think the only use case for PureNativeButton was to pass it into createAnimatedComponent and wrap with a native gesture later. createAnimatedComponent now won't work with the new implementation due to the "sandwich" structure of the new button, so this use case is gone.

You'd most likely need to wrap the button with a view and animate that, while having the button styled in a way to adapt to the view changes. We could add that to the skill, with some note that the agent should ask or at least inform the user that it needs double checking.

m-bert added a commit that referenced this pull request Feb 12, 2026
## Description

This PR removes `PureNativeButton` from public API.

> [!NOTE]
> Docs for this are already present in #3968 

## Test plan

Check that it is not possible to import it from package.
@m-bert m-bert added the Documentation Documentation change/enhancement label Feb 16, 2026
@m-bert m-bert merged commit 0e74233 into main Feb 17, 2026
1 check passed
@m-bert m-bert deleted the @mbert/docs-buttons branch February 17, 2026 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Documentation Documentation change/enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments