Fix sharedState data race in backgroundProposalOutcome#132
Open
brunotm wants to merge 1 commit intosmartcontractkit:masterfrom
Open
Fix sharedState data race in backgroundProposalOutcome#132brunotm wants to merge 1 commit intosmartcontractkit:masterfrom
brunotm wants to merge 1 commit intosmartcontractkit:masterfrom
Conversation
…utcomeInputsDigest instead of the unsynchronized sharedState.committedOutcome
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change fixes a unsynchronised access to outgen.sharedState.committedOutcome, by using the captured outctx.PreviousOutcome from the shared state which is passed by value to backgroundProposalOutcome.
Write at commit() at outcome_generation_follower.go:846 outgen.sharedState.committedOutcome = commit.Outcome
Read at backgroundProposalOutcome() at outcome_generation_follower.go:499 outgen.sharedState.committedOutcome when calling MakeOutcomeInputsDigest()
https://github.com/smartcontractkit/chainlink/actions/runs/22384997421/job/64793669658