Adding aptos service implementation by yashnevatia · Pull Request #340 · smartcontractkit/chainlink-aptos

yashnevatia · 2026-02-16T16:47:53Z

relayer/aptos_service.go

+
+		balance, err := client.AccountAPTBalance(addr)
+		if err != nil {
+			s.logger.Warnw("failed to get balance for account, skipping", "account", account, "address", addr.String(), "error", err)


General approach: avoid logging the potentially sensitive authKey/account address in clear text. Keep logging contextual, non-sensitive data (e.g., the public-key identifier or error) while omitting or redacting the address. Since the functional behavior of the method is independent of logging, we can safely adjust the log message without changing logic.

Best targeted fix: in relayer/aptos_service.go, inside getAccountWithHighestBalance, modify the warning log in the error path of client.AccountAPTBalance(addr) so it no longer logs addr.String(). We can either remove the "address" field entirely or replace it with a redacted placeholder. To be conservative and minimize code changes, we’ll just drop the "address", addr.String() pair. The rest of the log (account identifier and error) remains, so operational debugging is still possible.

Concrete changes:

File: relayer/aptos_service.go

In getAccountWithHighestBalance, adjust line 249 so that the Warnw call does not include addr.String().

No new imports, methods, or types are required.

No changes are needed in relayer/utils/address.go, since the issue is at the logging sink.

relayer/txm/txm.go

…-aptos into aptos-service

relayer/txm/txm.go

+
+	acc := utils.Ed25519PublicKeyToAddress(ed25519PublicKey)
+	fromAddress := acc.String()
+	a.baseLogger.Infow("TestingAptosWriteCap: EnqueueCRE - resolved from address", "fromAddress", fromAddress)


relayer/txm/txm.go

+	fromAccountAddress := &aptos.AccountAddress{}
+	err = fromAccountAddress.ParseStringRelaxed(fromAddress)
+	if err != nil {
+		a.baseLogger.Errorw("TestingAptosWriteCap: EnqueueCRE - failed to parse from address", "fromAddress", fromAddress, "error", err)


In general, to fix clear-text logging of sensitive information, avoid sending full sensitive values (keys, tokens, auth-related IDs) directly to logging sinks. Instead, either omit them entirely, or log only non-sensitive derivatives (like hashes) or redacted forms (like the last few characters) that are sufficient for correlation and debugging without revealing the full value.

In this case, fromAddress is derived from the auth key and then logged twice: once at info level when resolved, and once in the error log if parsing fails. To retain debuggability while avoiding full clear-text exposure, we can log a redacted version of the address (for example, log only the first 6 and last 4 hex characters) under a different key, such as "fromAddressSuffix" or "fromAddressRedacted". This keeps the logs useful to correlate which address caused an error, but prevents dumping the entire address. Concretely, in relayer/txm/txm.go we should replace the Infow and Errorw calls that pass "fromAddress", fromAddress with ones that pass a redacted representation, implemented inline (simple string slicing) so we don't need new imports or utilities. No other functional behavior of the transaction manager or address utilities needs to change.

Specifically:

In relayer/txm/txm.go, around lines 279–286:

After computing fromAddress := acc.String(), derive a redacted form (e.g., fromAddressRedacted := redactAddress(fromAddress) implemented inline as local logic).

Update the Infow call at line 281 to log "fromAddressRedacted", fromAddressRedacted instead of the full fromAddress.

Update the Errorw call at line 286 to log the same redacted address instead of the full fromAddress.
Because we cannot assume other parts of the file, we'll implement the redaction logic directly in the function body as a small helper closure or simple inline code, avoiding new package-level functions and imports.

relayer/txm/txm.go

+
+	select {
+	case a.broadcastChan <- transactionID:
+		ctxLogger.Infow("TestingAptosWriteCap: EnqueueCRE - tx enqueued to broadcast channel", "fromAddr", fromAddress, "transactionID", transactionID)


General fix: avoid logging the full value derived from authKey (fromAddress) in clear text. Either do not log it at all, or log only a redacted/hashed version that is not useful to an attacker but still allows operators to correlate events.

Best concrete fix here:

Replace the info log that prints "fromAddress" (line 281) with a version that logs a redacted form of the address (e.g., first 6 and last 4 characters, or just a hash).

In the ctxLogger.Infow call on line 325, stop logging fromAddr entirely (or also use the redacted value). Since the AptosTx is already stored with FromAddress, operators can still correlate by transactionID without needing the raw address in logs.

Implement a small helper function in relayer/utils/address.go to redact an address string, and use that in txm.go. This keeps redaction logic centralized and reusable.

Add no new external dependencies; use only standard string operations.

Specifically:

In relayer/utils/address.go, add a RedactAddressString(addr string) string helper that returns a partially masked address (if the string is long enough) or a constant like "[redacted]" if not.

In relayer/txm/txm.go:

After computing fromAddress, compute redactedFromAddress := utils.RedactAddressString(fromAddress) and log only the redacted value in the "resolved from address" log.

In the ctxLogger.Infow("...tx enqueued..." call, replace "fromAddr", fromAddress with "fromAddr", redactedFromAddress.

This preserves existing behavior except for the content of logs, and avoids emitting the full auth-derived address.

Adding aptos service implementation

eac7f5c

yashnevatia requested a review from a team as a code owner February 16, 2026 16:47

github-advanced-security bot found potential problems Feb 16, 2026

View reviewed changes

yashnevatia added 2 commits February 17, 2026 12:11

Adding EnqueueCRE test, cannot run locally, trying on CI

4283546

Merge branch 'develop' of ssh://github.com/smartcontractkit/chainlink…

e5b0369

…-aptos into aptos-service

yashnevatia had a problem deploying to integration February 17, 2026 12:17 — with GitHub Actions Error

tidy

3ce182f

yashnevatia had a problem deploying to integration February 17, 2026 12:22 — with GitHub Actions Error

tidy

55d4e2c

yashnevatia temporarily deployed to integration February 17, 2026 12:32 — with GitHub Actions Inactive

function name

c7c93d0

yashnevatia temporarily deployed to integration February 17, 2026 13:17 — with GitHub Actions Inactive

wait for cre txs

9bee276

yashnevatia temporarily deployed to integration February 17, 2026 13:42 — with GitHub Actions Inactive

adding serialised params

aafdb92

yashnevatia temporarily deployed to integration February 17, 2026 14:08 — with GitHub Actions Inactive

yashnevatia added 7 commits February 17, 2026 20:21

clean

e180775

wip

517566a

forwarder comments

1bbc29e

wip

abfd050

comments

01d90e1

adding beholder monitoring to aptos txm

8731df5

bump common to main

7979213

yashnevatia marked this pull request as draft March 5, 2026 18:51

yashnevatia requested a review from Fletch153 March 6, 2026 10:09

support for hash and status

c254a66

github-advanced-security bot found potential problems Mar 6, 2026

View reviewed changes

@@ -278,12 +278,20 @@
             	acc := utils.Ed25519PublicKeyToAddress(ed25519PublicKey)
             	fromAddress := acc.String()
-            	a.baseLogger.Infow("TestingAptosWriteCap: EnqueueCRE - resolved from address", "fromAddress", fromAddress)
+            	// Redact fromAddress in logs to avoid writing full auth-derived address in clear text.
+            	fromAddressRedacted := fromAddress
+            	if len(fromAddress) > 10 {
+            		// keep first 6 and last 4 characters for correlation
+            		fromAddressRedacted = fromAddress[:6] + "..." + fromAddress[len(fromAddress)-4:]
+            	}
+            	a.baseLogger.Infow("TestingAptosWriteCap: EnqueueCRE - resolved from address", "fromAddressRedacted", fromAddressRedacted)
             	fromAccountAddress := &aptos.AccountAddress{}
             	err = fromAccountAddress.ParseStringRelaxed(fromAddress)
             	if err != nil {
-            		a.baseLogger.Errorw("TestingAptosWriteCap: EnqueueCRE - failed to parse from address", "fromAddress", fromAddress, "error", err)
+            		a.baseLogger.Errorw("TestingAptosWriteCap: EnqueueCRE - failed to parse from address", "fromAddressRedacted", fromAddressRedacted, "error", err)
             		return fmt.Errorf("failed to parse from address: %+w", err)
             	}

@@ -30,6 +30,26 @@
             	return aptos.AccountAddress(authKey)
             }
+            // RedactAddressString returns a redacted representation of an address string suitable for logging.
+            // It avoids exposing the full authKey-derived address in clear text logs while still allowing
+            // basic correlation and debugging.
+            func RedactAddressString(addr string) string {
+            	const redactedPlaceholder = "[redacted]"
+            	if len(addr) <= 10 {
+            		// Too short to safely show parts; just indicate redacted.
+            		return redactedPlaceholder
+            	}
+            	prefixLen := 6
+            	suffixLen := 4
+            	if len(addr) < prefixLen+suffixLen {
+            		// Fallback in unusual cases.
+            		return redactedPlaceholder
+            	}
+            	return addr[:prefixLen] + "..." + addr[len(addr)-suffixLen:]
+            }
             func HexPublicKeyToAddress(key string) (aptos.AccountAddress, error) {
             	publicKey, err := HexPublicKeyToEd25519PublicKey(key)
             	if err != nil {

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding aptos service implementation#340

Adding aptos service implementation#340
yashnevatia wants to merge 16 commits intodevelopfrom
aptos-service

yashnevatia commented Feb 16, 2026 •

edited

Loading

Uh oh!

Check failure

Copilot Autofix

Uh oh!

Check failure

Copilot Autofix

Check failure

Copilot Autofix

Check failure

Copilot Autofix

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

yashnevatia commented Feb 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Check failure

Uh oh!

Copilot Autofix

Uh oh!

Check failure

Uh oh!

Copilot Autofix

Check failure

Uh oh!

Copilot Autofix

Check failure

Uh oh!

Copilot Autofix

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

yashnevatia commented Feb 16, 2026 •

edited

Loading