Add JSON support for UDF inputs and outputs #98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add timestamp=3 to msgpack.unpackb() to convert msgpack Timestamps to Python datetime objects - Add datetime=True to msgpack.packb() to properly serialize datetime objects back to msgpack Timestamps - Fix segfault in accel.c dump_rowdat_1 by adding NULL check after apply_transformer call - Add unit tests for msgpack timestamp functionality - Add UDF test functions for timestamp handling across numpy, pandas, polars, list, and non-vector types - Fix .gitignore to only ignore test*.py at root level Co-Authored-By: Claude Opus 4.5 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch includes support for JSON inputs and outputs for UDFs. This includes ways of specifying the JSON SQL type and applying transformers on the inputs and outputs to translate to and from strings that the database engine requires. Rather than just supporting a JSON type, this branch implements a way of specifying custom types with a specific SQL type for the input / output, and transformer functions for the inputs and outputs. These are wrapper in an
Annotatedobject in the Python type annotation and can be used by customers as well as internal developers for creating new types. This process will eventually be used to support the vector types and other complex SingleStoreDB types.