Fix LT-22355: Crash after typing a letter in Find dialog box#694
Open
jtmaxwell3 wants to merge 3 commits intomainfrom
Open
Fix LT-22355: Crash after typing a letter in Find dialog box#694jtmaxwell3 wants to merge 3 commits intomainfrom
jtmaxwell3 wants to merge 3 commits intomainfrom
Conversation
papeh
requested changes
Feb 24, 2026
Src/xWorks/XhtmlDocView.cs
Outdated
| { | ||
| if (geckoBrowser.Document == null) | ||
| { | ||
| view.StatusText = "No Document"; |
Contributor
There was a problem hiding this comment.
this string should be pulled from xWorksStrings.resx so that it can be localized.
Src/xWorks/XhtmlDocView.cs
Outdated
| string newResults = string.Empty; | ||
| if (geckoBrowser.Document == null) | ||
| { | ||
| results = newResults.Split(new[] { ';' }, StringSplitOptions.RemoveEmptyEntries); |
Contributor
There was a problem hiding this comment.
newResults is always string.Empty here. Can this line be simplified or removed?
Collaborator
Author
There was a problem hiding this comment.
I changed to results = null, which obviated the need for "No Document".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes https://jira.sil.org/browse/LT-22355.
This change is