no-issue: disable tests conditionally when binary is not present#1191
Open
ricardozanini wants to merge 4 commits intoserverlessworkflow:mainfrom
Open
no-issue: disable tests conditionally when binary is not present#1191ricardozanini wants to merge 4 commits intoserverlessworkflow:mainfrom
ricardozanini wants to merge 4 commits intoserverlessworkflow:mainfrom
Conversation
Signed-off-by: Ricardo Zanini <ricardozanini@gmail.com>
Signed-off-by: Ricardo Zanini <ricardozanini@gmail.com>
There was a problem hiding this comment.
Pull request overview
Adds a JUnit 5 annotation/extension to conditionally disable tests when required external binaries (e.g., protoc, python) are not available on the executing machine, improving mvn clean install reliability across environments.
Changes:
- Introduce
@DisabledIfBinaryUnavailableplusBinaryCheckConditionJUnit 5ExecutionCondition. - Apply the new annotation to gRPC tests requiring
protoc. - Apply the new annotation to the parameterized custom function test requiring
python.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| impl/test/src/test/java/io/serverlessworkflow/impl/test/junit/DisabledIfBinaryUnavailable.java | New annotation to register the binary-check execution condition. |
| impl/test/src/test/java/io/serverlessworkflow/impl/test/junit/BinaryCheckCondition.java | New JUnit 5 ExecutionCondition that runs a command to determine binary availability. |
| impl/test/src/test/java/io/serverlessworkflow/impl/test/grpc/GrpcUnaryTest.java | Disable test class when protoc is unavailable. |
| impl/test/src/test/java/io/serverlessworkflow/impl/test/grpc/GrpcUnaryArgsExprTest.java | Disable test class when protoc is unavailable. |
| impl/test/src/test/java/io/serverlessworkflow/impl/test/grpc/GrpcServerStreamingTest.java | Disable test class when protoc is unavailable. |
| impl/test/src/test/java/io/serverlessworkflow/impl/test/grpc/GrpcClientStreamingTest.java | Disable test class when protoc is unavailable. |
| impl/test/src/test/java/io/serverlessworkflow/impl/test/grpc/GrpcBiDirectionalStreamingTest.java | Disable test class when protoc is unavailable. |
| impl/test/src/test/java/io/serverlessworkflow/impl/test/CustomFunctionTest.java | Disable the python-dependent parameterized test when python is unavailable. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
impl/test/src/test/java/io/serverlessworkflow/impl/test/junit/BinaryCheckCondition.java
Outdated
Show resolved
Hide resolved
impl/test/src/test/java/io/serverlessworkflow/impl/test/junit/BinaryCheckCondition.java
Outdated
Show resolved
Hide resolved
impl/test/src/test/java/io/serverlessworkflow/impl/test/junit/BinaryCheckCondition.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Ricardo Zanini <ricardozanini@gmail.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated 6 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
impl/test/src/test/java/io/serverlessworkflow/impl/test/grpc/GrpcUnaryTest.java
Outdated
Show resolved
Hide resolved
impl/test/src/test/java/io/serverlessworkflow/impl/test/grpc/GrpcUnaryArgsExprTest.java
Outdated
Show resolved
Hide resolved
impl/test/src/test/java/io/serverlessworkflow/impl/test/grpc/GrpcServerStreamingTest.java
Outdated
Show resolved
Hide resolved
impl/test/src/test/java/io/serverlessworkflow/impl/test/grpc/GrpcClientStreamingTest.java
Outdated
Show resolved
Hide resolved
.../test/src/test/java/io/serverlessworkflow/impl/test/grpc/GrpcBiDirectionalStreamingTest.java
Outdated
Show resolved
Hide resolved
impl/test/src/test/java/io/serverlessworkflow/impl/test/junit/BinaryCheckCondition.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Ricardo Zanini <ricardozanini@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Many thanks for submitting your Pull Request ❤️!
What this PR does / why we need it:
Sometimes, a local machine environment might not have
pythonorprotocinstalled to run "unit" tests. In my opinion, these tests should be ITs and be on a specific profile.However, if we want to run as unit tests and they depend on the environment where they're running, we disable the test if needed.
Special notes for reviewers:
mvn clean installnow runs smoothly if python or grpc are not available.Additional information (if needed):