fix: TypeScript model generation - use declare on all class fields and methods#628
Open
duki994 wants to merge 1 commit intosequelize:masterfrom
Open
fix: TypeScript model generation - use declare on all class fields and methods#628duki994 wants to merge 1 commit intosequelize:masterfrom
declare on all class fields and methods#628duki994 wants to merge 1 commit intosequelize:masterfrom
Conversation
IlyaJurgens
approved these changes
Dec 9, 2022
|
We would like to see this merged as it is currently causing issues in our TypeScript/ES2022 target codebase. What needs to be done to see this included? |
Author
Haven't worked in JS/TS ecosystem for a while. I'll commit some of my OSS time to fix the issues as this modification had so many use cases across all TS projects I ever did. |
|
I too would like this merged as the lack of |
|
I need this too. |
|
please merge this... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
declareall class fields … https://sequelize.org/docs/v6/core-concepts/model-basics/#caveat-with-public-class-fieldsDescription
All model classes were generated without
declarekeyword which made TypeScript to shadow Sequelize generated models.Future plans
Create a PR with changes to code to use new
InferAtributesandInferCreationAttributes