WIP: Dockerize databases to speed-up local testing#502
Draft
jsau- wants to merge 4 commits intosequelize:masterfrom
Draft
WIP: Dockerize databases to speed-up local testing#502jsau- wants to merge 4 commits intosequelize:masterfrom
jsau- wants to merge 4 commits intosequelize:masterfrom
Conversation
Previously we mixed 'Northwind' and 'northwind' across the mysql migrations, causing failures on execution. Changed to consistent lowercase
Collaborator
|
@jsau- I updated the mssql scripts in sample/dbscripts (in the |
Author
|
Awesome, thanks, I just took a quick look and I'm still getting the same error. I should have some time this weekend to properly look at it - it'll likely be something wrong with what I'm doing; I ran everything from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds Docker containers for supported database types to speed up testing.
Relates to: #478
Outstanding issues: On boot the
mssqlcontainer complains about errors, seems that the model script might have problems?