chore: many refactor with breaking api changes#83
Open
lightsing wants to merge 3 commits intofix/output-no-errorfrom
Open
chore: many refactor with breaking api changes#83lightsing wants to merge 3 commits intofix/output-no-errorfrom
lightsing wants to merge 3 commits intofix/output-no-errorfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR introduces significant refactoring with breaking API changes, including:
- Migration from
rlptoalloy-rlpfor RLP encoding/decoding - Introduction of lifetime parameters and
Cowtypes for zero-copy optimizations - Refactored error handling with a new
Responseenum andRpcErrortype - Simplified version handling by moving version initialization to build-time
- Reorganized configuration with
suppress_empty_task_errormoved fromProverConfigtoCoordinatorConfig
Key Changes
- Enhanced type safety with derive macros (
EnumIs,FromRepr,Display) replacing manual implementations - Improved token management using
OnceCellandArcfor concurrent access - Consolidated API request handling into a single generic
requestmethod
Reviewed changes
Copilot reviewed 15 out of 16 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/utils.rs | Replaced runtime version initialization with compile-time constant using env! macros |
| src/prover/types.rs | Migrated to derive macros and alloy-rlp for enum serialization |
| src/prover/mod.rs | Removed test module, refactored task retrieval logic, updated to use Cow types |
| src/prover/builder.rs | Updated to pass suppress_empty_task_error to coordinator client |
| src/coordinator_handler/types.rs | Complete refactor of response handling and type definitions with zero-copy optimizations |
| src/coordinator_handler/key_signer.rs | Minor import reordering |
| src/coordinator_handler/error.rs | Renamed error variants and added EnumIs derive |
| src/coordinator_handler/coordinator_client.rs | Refactored token management and error handling |
| src/coordinator_handler/api.rs | Consolidated request methods into generic request function |
| src/config.rs | Moved suppress_empty_task_error field to CoordinatorConfig |
| rust-toolchain.toml | Updated nightly channel version |
| examples/local.rs | Import reordering |
| examples/cloud.rs | Import reordering |
| build.rs | New file for build-time environment variable setup |
| Cargo.toml | Updated version, edition, and dependencies |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.