fix: compiled page fixes #711
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Henry Schreiner <[email protected]>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes and improves the compiled packaging documentation based on issue #710. It provides clearer guidance on backend selection, adds helpful notes about build system requirements, and updates version requirements for SPDX license support.
- Adds concrete guidance for selecting between different build backends (maturin, scikit-build-core, meson-python)
- Adds clarifying notes about build system requirements (gitignore handling, LICENSE/README requirements)
- Updates SPDX license support information to include maturin and meson-python with their version requirements
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| docs/pages/guides/packaging_compiled.md | Adds backend selection guidance, clarifies scikit-build-core gitignore handling, documents Meson file requirements, and adds missing Maturin example heading |
| docs/_includes/pyproject.md | Adds version field to example and updates SPDX license support versions to include previously unsupported backends |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting fixes based on #710.
📚 Documentation preview 📚: https://scientific-python-cookie--711.org.readthedocs.build/