Skip to content

Comments

Update LastModified date format to ISO string in XML response#6085

Merged
bert-e merged 2 commits intodevelopment/9.3from
bugfix/CLDSRV-857/last-modified-format
Feb 24, 2026
Merged

Update LastModified date format to ISO string in XML response#6085
bert-e merged 2 commits intodevelopment/9.3from
bugfix/CLDSRV-857/last-modified-format

Conversation

@ZiyangLinScality
Copy link

@ZiyangLinScality ZiyangLinScality commented Feb 23, 2026

Issue CLDSRV-857

When browsing objects created by Veeam SOSAPI, the UI shows "An error occurred while loading data" even though the API returns a 200 response with valid XML.

Root cause: The LastModified field in the response uses RFC 2822 format (Mon, 23 Feb 2026 08:24:20 GMT) instead of ISO 8601 (2026-02-23T08:24:20.000Z). AWS SDK v3 strictly expects RFC 3339/ISO 8601 and throws TypeError: Invalid RFC3339 timestamp format during deserialization, causing the entire response to fail.

@bert-e
Copy link
Contributor

bert-e commented Feb 23, 2026

Hello ziyanglinscality,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@bert-e

This comment was marked as resolved.

@ZiyangLinScality ZiyangLinScality changed the base branch from development/9.2 to development/9.3 February 23, 2026 15:04
@ZiyangLinScality ZiyangLinScality force-pushed the bugfix/CLDSRV-857/last-modified-format branch from 391b803 to adc7c94 Compare February 23, 2026 15:05
@bert-e
Copy link
Contributor

bert-e commented Feb 23, 2026

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

@scality scality deleted a comment from bert-e Feb 23, 2026
@codecov
Copy link

codecov bot commented Feb 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.26%. Comparing base (2a7a68f) to head (6002c51).
⚠️ Report is 5 commits behind head on development/9.3.
✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

Files with missing lines Coverage Δ
lib/routes/veeam/list.js 97.50% <ø> (ø)

... and 3 files with indirect coverage changes

@@                 Coverage Diff                 @@
##           development/9.3    #6085      +/-   ##
===================================================
- Coverage            84.31%   84.26%   -0.05%     
===================================================
  Files                  206      206              
  Lines                13251    13251              
===================================================
- Hits                 11172    11166       -6     
- Misses                2079     2085       +6     
Flag Coverage Δ
file-ft-tests 67.90% <ø> (-0.02%) ⬇️
kmip-ft-tests 28.08% <ø> (-0.04%) ⬇️
mongo-v0-ft-tests 69.13% <ø> (ø)
mongo-v1-ft-tests 69.22% <ø> (ø)
multiple-backend 35.10% <ø> (ø)
sur-tests 35.63% <ø> (-0.04%) ⬇️
sur-tests-inflights 37.49% <ø> (ø)
unit 69.90% <ø> (ø)
utapi-v2-tests 34.36% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bert-e
Copy link
Contributor

bert-e commented Feb 23, 2026

Incorrect fix version

The Fix Version/s in issue CLDSRV-857 contains:

  • 9.3.4

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 9.3.5

Please check the Fix Version/s of CLDSRV-857, or the target
branch of this pull request.

Copy link
Contributor

@DarkIsDude DarkIsDude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should have test somehow 🙏

Copy link
Contributor

@anurag4DSB anurag4DSB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets add the test and then we should be good.

Add a regression test that captures the XML body from the LIST
route and verifies all LastModified values match ISO 8601 format,
preventing the RFC 2822 date format bug from recurring.
@ZiyangLinScality ZiyangLinScality force-pushed the bugfix/CLDSRV-857/last-modified-format branch from 4f11a1f to 6002c51 Compare February 24, 2026 09:55
@ZiyangLinScality
Copy link
Author

/approve

@bert-e
Copy link
Contributor

bert-e commented Feb 24, 2026

Incorrect fix version

The Fix Version/s in issue CLDSRV-857 contains:

  • 9.3.4

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 9.3.5

Please check the Fix Version/s of CLDSRV-857, or the target
branch of this pull request.

The following options are set: approve

@ZiyangLinScality
Copy link
Author

/status

@bert-e
Copy link
Contributor

bert-e commented Feb 24, 2026

Status

Status report is not available.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Feb 24, 2026

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

  • ✔️ development/9.3

The following branches will NOT be impacted:

  • development/7.10
  • development/7.4
  • development/7.70
  • development/8.8
  • development/9.0
  • development/9.1
  • development/9.2

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

  • Any commit you add on the source branch will trigger a new cycle after the
    current queue is merged.
  • Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Feb 24, 2026

Queue build failed

The corresponding build for the queue failed:

  • Checkout the status page.
  • Identify the failing build and review the logs.
  • If no issue is found, re-run the build.
  • If an issue is identified, checkout the steps below to remove
    the pull request from the queue for further analysis and maybe rebase/merge.
Remove the pull request from the queue
  • Add a /wait comment on this pull request.
  • Click on login on the status page.
  • Go into the manage page.
  • Find the option called Rebuild the queue and click on it.
    Bert-E will loop again on all pull requests to put the valid ones
    in the queue again, while skipping the one with the /wait comment.
  • Wait for the new queue to merge, then merge/rebase your pull request
    with the latest changes to then work on a proper fix.
  • Once the issue is fixed, delete the /wait comment and
    follow the usual process to merge the pull request.

@bert-e
Copy link
Contributor

bert-e commented Feb 24, 2026

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/9.3

The following branches have NOT changed:

  • development/7.10
  • development/7.4
  • development/7.70
  • development/8.8
  • development/9.0
  • development/9.1
  • development/9.2

Please check the status of the associated issue CLDSRV-857.

Goodbye ziyanglinscality.

@bert-e bert-e merged commit 9684045 into development/9.3 Feb 24, 2026
48 of 51 checks passed
@bert-e bert-e deleted the bugfix/CLDSRV-857/last-modified-format branch February 24, 2026 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants