Skip to content

Conversation

@BourgoisMickael
Copy link
Contributor

@BourgoisMickael BourgoisMickael commented Nov 15, 2025

This will help correlate connection with zookeeper logs that show client port and session id

{"name":"Backbeat:Notification:QueueProcessor","time":1767700325481,"state":{"name":"SYNC_CONNECTED","code":3},"method":"ZookeeperManager.on.state","zk":{"sessionId":"0x0300001c3694000a","socket":"127.0.0.1:55702","state":{"name":"SYNC_CONNECTED","code":3},"xid":0,"zxid":"0000000000000000","nextServerIndex":1,"serverAttempts":0},"level":"info","message":"zookeeper new state","hostname":"rocky-8-3xl-nd-gcloud-707990ef-9e40-49f4-8bd6-29e3cf76e111","pid":34}

@codecov
Copy link

codecov bot commented Nov 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.07%. Comparing base (f4614f2) to head (a45e5d1).

Additional details and impacted files

Impacted file tree graph

Files with missing lines Coverage Δ
lib/clients/ZookeeperManager.js 94.33% <100.00%> (+0.46%) ⬆️

... and 1 file with indirect coverage changes

Components Coverage Δ
Bucket Notification 80.25% <ø> (ø)
Core Library 80.34% <100.00%> (+0.04%) ⬆️
Ingestion 70.28% <ø> (ø)
Lifecycle 78.67% <ø> (ø)
Oplog Populator 85.06% <ø> (ø)
Replication 58.62% <ø> (ø)
Bucket Scanner 85.76% <ø> (ø)
@@                       Coverage Diff                        @@
##           improvement/BB-727-zk-config    #2688      +/-   ##
================================================================
+ Coverage                         74.05%   74.07%   +0.02%     
================================================================
  Files                               201      201              
  Lines                             13477    13485       +8     
================================================================
+ Hits                               9980     9989       +9     
+ Misses                             3487     3486       -1     
  Partials                             10       10              
Flag Coverage Δ
api:retry 9.47% <60.00%> (+0.03%) ⬆️
api:routes 9.28% <60.00%> (+0.03%) ⬆️
bucket-scanner 85.76% <ø> (ø)
ft_test:queuepopulator 8.93% <60.00%> (+0.03%) ⬆️
ingestion 12.53% <60.00%> (+0.03%) ⬆️
lib 7.52% <100.00%> (+0.06%) ⬆️
lifecycle 18.68% <60.00%> (+0.03%) ⬆️
notification 1.03% <0.00%> (-0.01%) ⬇️
replication 18.43% <0.00%> (-0.02%) ⬇️
unit 50.12% <80.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@BourgoisMickael BourgoisMickael changed the title BB-727: Fix comment typo BB-727: Log Zookeeper details Nov 16, 2025
@BourgoisMickael BourgoisMickael force-pushed the improvement/BB-727-zk-config branch from 694086a to 66d8b1a Compare January 5, 2026 10:44
@BourgoisMickael BourgoisMickael force-pushed the improvement/BB-727-zk-logs branch from e223d14 to e3263af Compare January 5, 2026 10:55
@BourgoisMickael BourgoisMickael force-pushed the improvement/BB-727-zk-config branch from 7edd397 to 80072f1 Compare January 5, 2026 14:27
@BourgoisMickael BourgoisMickael force-pushed the improvement/BB-727-zk-logs branch from e3263af to bed3737 Compare January 5, 2026 14:29
@BourgoisMickael BourgoisMickael force-pushed the improvement/BB-727-zk-config branch from 80072f1 to 3dc379d Compare January 5, 2026 14:55
@BourgoisMickael BourgoisMickael force-pushed the improvement/BB-727-zk-logs branch from bed3737 to ff6a067 Compare January 5, 2026 14:56
@BourgoisMickael BourgoisMickael force-pushed the improvement/BB-727-zk-config branch from 3dc379d to f4614f2 Compare January 5, 2026 16:17
@BourgoisMickael BourgoisMickael force-pushed the improvement/BB-727-zk-logs branch 2 times, most recently from 494105f to 1f9f870 Compare January 5, 2026 17:00
@BourgoisMickael BourgoisMickael marked this pull request as ready for review January 5, 2026 17:00
@BourgoisMickael BourgoisMickael changed the base branch from improvement/BB-727-zk-config to development/9.0 January 5, 2026 17:00
@bert-e
Copy link
Contributor

bert-e commented Jan 5, 2026

Hello bourgoismickael,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Jan 5, 2026

Request integration branches

Waiting for integration branch creation to be requested by the user.

To request integration branches, please comment on this pull request with the following command:

/create_integration_branches

Alternatively, the /approve and /create_pull_requests commands will automatically
create the integration branches.

@BourgoisMickael BourgoisMickael changed the base branch from development/9.0 to improvement/BB-727-zk-config January 5, 2026 17:21
@BourgoisMickael BourgoisMickael force-pushed the improvement/BB-727-zk-logs branch from 1f9f870 to a45e5d1 Compare January 5, 2026 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants