Skip to content

Conversation

@delthas
Copy link

@delthas delthas commented Dec 24, 2025

Issue: ZENKO-5106

@bert-e
Copy link
Contributor

bert-e commented Dec 24, 2025

Hello delthas,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for testing SASL_PLAIN authenticated Kafka listeners with bucket notifications. It configures a new Kafka listener with SASL authentication and creates the necessary test infrastructure to verify notifications work with authenticated Kafka endpoints.

  • Adds a third notification destination with SASL_PLAIN authentication support
  • Configures a new Kafka listener on port 9095 with SASL authentication
  • Extends test parameters and environment variables to support authenticated notifications

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
tests/ctst/world/Zenko.ts Adds interface properties for authenticated notification destination configuration
tests/ctst/steps/notifications.ts Implements test step for setting up an authenticated notification destination
.github/workflows/end2end.yaml Defines environment variables for authenticated destination credentials and topic
.github/scripts/end2end/run-e2e-ctst.sh Passes authenticated notification parameters to test world configuration
.github/scripts/end2end/configure-e2e.sh Adds Kafka topic creation for authenticated notification destination
.github/scripts/end2end/configure-e2e-ctst.sh Configures SASL_PLAIN Kafka listener and creates authenticated notification topic
.github/scripts/end2end/configs/notification_destinations.yaml Defines ZenkoNotificationTarget with basic authentication credentials

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@delthas delthas force-pushed the improvement/ZENKO-5106/kafka-sasl-plain branch from 47079c0 to 84be537 Compare December 24, 2025 12:24
@scality scality deleted a comment from bert-e Dec 24, 2025
@bert-e
Copy link
Contributor

bert-e commented Dec 24, 2025

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

@delthas delthas force-pushed the improvement/ZENKO-5106/kafka-sasl-plain branch 2 times, most recently from ce70bd5 to 8c5d50f Compare December 24, 2025 16:12
@delthas delthas force-pushed the improvement/ZENKO-5106/kafka-sasl-plain branch from 8c5d50f to de82fb9 Compare December 24, 2025 16:33
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants