-
Notifications
You must be signed in to change notification settings - Fork 92
Deploy a SASL_PLAIN Kafka listener & test notifications against it #2300
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: development/2.13
Are you sure you want to change the base?
Conversation
Hello delthas,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds support for testing SASL_PLAIN authenticated Kafka listeners with bucket notifications. It configures a new Kafka listener with SASL authentication and creates the necessary test infrastructure to verify notifications work with authenticated Kafka endpoints.
- Adds a third notification destination with SASL_PLAIN authentication support
- Configures a new Kafka listener on port 9095 with SASL authentication
- Extends test parameters and environment variables to support authenticated notifications
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/ctst/world/Zenko.ts | Adds interface properties for authenticated notification destination configuration |
| tests/ctst/steps/notifications.ts | Implements test step for setting up an authenticated notification destination |
| .github/workflows/end2end.yaml | Defines environment variables for authenticated destination credentials and topic |
| .github/scripts/end2end/run-e2e-ctst.sh | Passes authenticated notification parameters to test world configuration |
| .github/scripts/end2end/configure-e2e.sh | Adds Kafka topic creation for authenticated notification destination |
| .github/scripts/end2end/configure-e2e-ctst.sh | Configures SASL_PLAIN Kafka listener and creates authenticated notification topic |
| .github/scripts/end2end/configs/notification_destinations.yaml | Defines ZenkoNotificationTarget with basic authentication credentials |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
47079c0 to
84be537
Compare
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
|
Issue: ZENKO-5106 Signed-off-by: Thomas Flament <[email protected]>
ce70bd5 to
8c5d50f
Compare
Signed-off-by: Thomas Flament <[email protected]>
8c5d50f to
de82fb9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
Issue: ZENKO-5106